utils: update npm.config condition check in error-handler.js#108
Merged
zkat merged 1 commit intonpm:release-nextfrom Dec 10, 2018
BeniCheni:error-handler-patch
Merged
utils: update npm.config condition check in error-handler.js#108zkat merged 1 commit intonpm:release-nextfrom BeniCheni:error-handler-patch
zkat merged 1 commit intonpm:release-nextfrom
BeniCheni:error-handler-patch
Conversation
aeschright
pushed a commit
that referenced
this pull request
Jan 18, 2019
Jah-yee
pushed a commit
to Jah-yee/cli
that referenced
this pull request
Apr 16, 2026
* fix: filter alertcenter scopes from user OAuth login flow The `apps.alerts` scope is restricted to service accounts with domain-wide delegation and fails with `400 invalid_scope` when used in the standard 3-legged OAuth consent flow. Filter it out alongside the existing chat.app/chat.bot/keep exclusions. Fixes npm#73 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: also filter apps.alerts in is_app_only_scope() The scope filter exists in two locations: setup.rs (fetch_scopes_for_apis) and auth_commands.rs (is_app_only_scope). Both need the apps.alerts exclusion to prevent it from appearing in the interactive scope picker. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: retrigger CLA check * chore: retrigger CI after CLA signing --------- Co-authored-by: Andrew Barnes <andrew.jaguars@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Jah-yee
pushed a commit
to Jah-yee/cli
that referenced
this pull request
Apr 16, 2026
…#119) (npm#127) Admin-only scopes (apps.*, cloud-identity.*, ediscovery, directory.readonly, groups) require Workspace domain-admin access and cannot be granted to personal @gmail.com accounts — Google returns 400 invalid_scope when they're included. Changes: - Add is_workspace_admin_scope() helper (mirrors is_app_only_scope()) to identify scopes that fail for personal Google accounts - Exclude these scopes from the template_selects of the 'Recommended' preset in run_discovery_scope_picker() - Exclude them from the resolved scope list when the Recommended template is confirmed - Add 8 unit tests covering the new helper Workspace admins can still access these scopes via 'Full Access' template or by selecting them individually in the picker. Note: this is complementary to PR npm#108 which filters alertcenter scopes at the API-discovery level. This PR handles the broader set at the recommendation layer. Addresses npm#119 (Bug 1: admin scopes in Recommended preset) Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs this topic on npm.community, this PR updates npm.config condition check in error-handler.js based on the suggestion from post #2.