update: re-enable updating local packages by larsgw · Pull Request #73 · npm/cli

larsgw · 2018-10-02T18:28:16Z

PR npm/npm#11584 removed the possibility of updating local packages (linked with symlinks) with npm update.
Reason was that this functionality didn't work in v3.6.0. However, the system behind local dependencies
has since changed, and I can't reproduce the original error anymore.

Reverts 53cdb96
See discussion in https://npm.community/t/1725

zkat · 2018-11-13T15:00:57Z

I'd like an 👀 from @iarna on this one.

jmfNodejsUser · 2019-01-08T12:40:38Z

Hello,
Is this correction now available in 6.4.1 ?

iarna · 2019-01-08T16:46:07Z

@jmfNodejsUser It is not, it's not yet been merged.

iarna

Ok, it took me a bit to wrap my head around what this was doing:

This is fixing a problem where npm update won't auto-heal missing links. (The work around is to run npm i instead, which will.)

I approve of this idea, but there are two things that need to be addressed before it lands:

It needs a test (this would have helped us understand what the patch was hoping to achieve)
With this patch and a file: type dep, npm outdated -l crashes, this'll need to be fixed.

jmfNodejsUser · 2019-01-09T08:47:46Z

Thank you for the reply iarna.
How can I help to test this change? OR will somebody from the leader team test the modification?

Your suggestion to use npm i works and installs/links the first/primary dependency (local node module) in the main project. All sub dependencies of the local node modules are not installed/linked. Except when I delete the package-lock.json first and then run "npm i". In this case, it works and installs all primary and sub dependencies which are all local node modules(i.e. not from the npm registry)

jmfNodejsUser · 2019-01-10T13:51:05Z

The problem with using "npm i" is the same mentioned in
https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754

larsgw · 2019-01-18T20:50:38Z

Sorry for the confusion. I added tests. As for the npm outdated -l crash, that should be fixed in #124.

Make sure publishing with legacy username:password _auth works again

@watilde

PR-URL: npm#120 Credit: @watilde Reviewed-By: @aeschright

@watilde

PR-URL: npm#126 Credit: @watilde Reviewed-By: @aeschright

@elidoran

PR-URL: npm#138 Credit: @elidoran Reviewed-By: @aeschright

@larsgw

PR-URL: npm#144 Credit: @larsgw Reviewed-By: @aeschright

@sokra

PR-URL: npm#147 Fixes: https://npm.community/t/packages-with-peerdependencies-are-incorrectly-hoisted/4794 Credit: @sokra Reviewed-By: @aeschright

@larsgw

PR-URL: npm#145 Fixes: https://npm.community/t/4770 Credit: @larsgw Reviewed-By: @aeschright

@greysteil

…npm#140) PR-URL: npm#140 Credit: @greysteil Reviewed-By: @aeschright

@zkat

PR-URL: npm#149 Credit: @zkat Reviewed-By: @aeschright

@zkat

PR-URL: npm#151 Fixes: https://npm.community/t/npm-6-6-0-breaks-access-to-ls-collaborators/5101 Credit: @zkat Reviewed-By: @aeschright

jmfNodejsUser · 2019-02-05T10:27:57Z

Hello @zkat , @iarna ,
Has this correction been merged into version 6.7.0 release?
I tried downloading version 6.7.0 and testing it.
The "npm update" still does not work for local node modules.

@larsgw ,
This problem started after npm version 5.6.0 and exists till now. So I think, that the change in v3.6.0 is probably not the reason for these problems since 5.6.0.
The workaround by using "npm install" still needs a deletion of the package-lock.json.

PR #11584 removed the possibility of updating local packages (linked with symlinks) with `npm update`. Reason was that this functionality didn't work in v3.6.0. However, the system behind local dependencies has since changed, and I can't reproduce the original error anymore. Reverts 59e5056

zkat

Looks good! Thanks for fixing things up. This looks like it fulfill's @iarna's requirements, so we're good to go. 👍

@larsgw

PR #11584 removed the possibility of updating local packages (linked with symlinks) with `npm update`. Reason was that this functionality didn't work in v3.6.0. However, the system behind local dependencies has since changed, and I can't reproduce the original error anymore. Reverts 59e5056 Fixes: https://npm.community/t/1725?u=larsgw PR-URL: #73 Credit: @larsgw Reviewed-By: @iarna Reviewed-By: @zkat

zkat · 2019-02-18T22:56:24Z

This has been merged by hand. Thanks again, @larsgw!

* fix: filter alertcenter scopes from user OAuth login flow The `apps.alerts` scope is restricted to service accounts with domain-wide delegation and fails with `400 invalid_scope` when used in the standard 3-legged OAuth consent flow. Filter it out alongside the existing chat.app/chat.bot/keep exclusions. Fixes npm#73 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: also filter apps.alerts in is_app_only_scope() The scope filter exists in two locations: setup.rs (fetch_scopes_for_apis) and auth_commands.rs (is_app_only_scope). Both need the apps.alerts exclusion to prevent it from appearing in the interactive scope picker. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: retrigger CLA check * chore: retrigger CI after CLA signing --------- Co-authored-by: Andrew Barnes <andrew.jaguars@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

larsgw requested a review from a team as a code owner October 2, 2018 18:28

zkat changed the base branch from latest to release-next November 13, 2018 15:00

zkat added the needs-discussion label Nov 13, 2018

iarna suggested changes Jan 8, 2019

View reviewed changes

zkat force-pushed the release-next branch 2 times, most recently from 6ca2f43 to 6d0cc95 Compare January 18, 2019 19:17

zkat force-pushed the release-next branch 3 times, most recently from db63b89 to b09bc8c Compare January 23, 2019 18:36

zkat and others added 14 commits January 24, 2019 11:24

npm-registry-fetch@3.9.0

671cad1

Make sure publishing with legacy username:password _auth works again

doc: use const in lib/fetch-package-metadata.md (npm#120)

89b23a5

PR-URL: npm#120 Credit: @watilde Reviewed-By: @aeschright

misc: replace ronn with marked-man (npm#126)

4970d55

PR-URL: npm#126 Credit: @watilde Reviewed-By: @aeschright

Reduce work to test if executable ends with a 'g'. (npm#138)

d9b6090

PR-URL: npm#138 Credit: @elidoran Reviewed-By: @aeschright

test(maketest): Fix common.npm callback arguments (npm#144)

cdb0592

PR-URL: npm#144 Credit: @larsgw Reviewed-By: @aeschright

install/dedupe: fix hoisting of packages with peerDeps (npm#147)

91314e7

PR-URL: npm#147 Fixes: https://npm.community/t/packages-with-peerdependencies-are-incorrectly-hoisted/4794 Credit: @sokra Reviewed-By: @aeschright

ls: show installed but unmet peer deps (npm#145)

25573e9

PR-URL: npm#145 Fixes: https://npm.community/t/4770 Credit: @larsgw Reviewed-By: @aeschright

doc: update package.json docs to include repository.directory details (…

3663cde

…npm#140) PR-URL: npm#140 Credit: @greysteil Reviewed-By: @aeschright

token: use figgy-config to make sure extra opts are there (npm#149)

ce2c4bd

PR-URL: npm#149 Credit: @zkat Reviewed-By: @aeschright

pacote@9.4.1

95ca1ae

chore: add changelog for v6.8.0

dacc47d

update AUTHORS

f28a94c

6.8.0-next.0

309260d

access: ls-collaborators is ok with non-scoped (npm#151)

3c22d1a

PR-URL: npm#151 Fixes: https://npm.community/t/npm-6-6-0-breaks-access-to-ls-collaborators/5101 Credit: @zkat Reviewed-By: @aeschright

larsgw added 2 commits February 6, 2019 23:22

test: update & outdated local packages

4d16575

larsgw force-pushed the patch-2 branch from 3342686 to 4d16575 Compare February 6, 2019 22:23

zkat added semver:patch semver patch level for changes and removed needs-discussion labels Feb 11, 2019

zkat approved these changes Feb 11, 2019

View reviewed changes

zkat force-pushed the release-next branch from 3799d8e to 863baff Compare February 18, 2019 22:32

zkat closed this Feb 18, 2019

snyk-bot mentioned this pull request Jun 16, 2022

[Snyk] Upgrade @npmcli/run-script from 3.0.2 to 3.0.3 LadyK-21/cli#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update: re-enable updating local packages#73

update: re-enable updating local packages#73
larsgw wants to merge 16 commits intonpm:release-nextfrom
larsgw:patch-2

larsgw commented Oct 2, 2018 •

edited

Loading

Uh oh!

zkat commented Nov 13, 2018

Uh oh!

jmfNodejsUser commented Jan 8, 2019

Uh oh!

iarna commented Jan 8, 2019

Uh oh!

iarna left a comment •

edited

Loading

Uh oh!

jmfNodejsUser commented Jan 9, 2019

Uh oh!

jmfNodejsUser commented Jan 10, 2019

Uh oh!

larsgw commented Jan 18, 2019

Uh oh!

jmfNodejsUser commented Feb 5, 2019

Uh oh!

zkat left a comment

Uh oh!

zkat commented Feb 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

larsgw commented Oct 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zkat commented Nov 13, 2018

Uh oh!

jmfNodejsUser commented Jan 8, 2019

Uh oh!

iarna commented Jan 8, 2019

Uh oh!

iarna left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmfNodejsUser commented Jan 9, 2019

Uh oh!

jmfNodejsUser commented Jan 10, 2019

Uh oh!

larsgw commented Jan 18, 2019

Uh oh!

jmfNodejsUser commented Feb 5, 2019

Uh oh!

zkat left a comment

Choose a reason for hiding this comment

Uh oh!

zkat commented Feb 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

larsgw commented Oct 2, 2018 •

edited

Loading

iarna left a comment •

edited

Loading