[new task] Spatial decomposition#309
Merged
scottgigante-immunai merged 208 commits intoopenproblems-bio:mainfrom Jul 21, 2022
Merged
[new task] Spatial decomposition#309scottgigante-immunai merged 208 commits intoopenproblems-bio:mainfrom
scottgigante-immunai merged 208 commits intoopenproblems-bio:mainfrom
Conversation
Alma branch
Collaborator
Author
|
seems like it failed for rctd, I'd be happy to remove it for now |
Collaborator
|
Yes, let's pull out RCTD and fix that in a separate PR. |
Collaborator
|
I added an issue in the RCTD repo: dmcable/spacexr#90 |
Collaborator
Author
|
nfcore failed with |
Collaborator
|
Sounds like a flake. Updated from main to rerun. |
Collaborator
Author
|
@scottgigante-immunai tests seems to pass in my fork! Can you trigger CI here as well? then we can finally merge! |
LuckyMD
dismissed stale reviews from scottgigante-immunai and dburkhardt
Addressed by 2dd10e2
scottgigante-immunai
approved these changes
Jul 21, 2022
Collaborator
Author
|
😍 😍 lgtm? |
Collaborator
|
😍😍😍 |
Collaborator
|
Amazing work @giovp ! Now we're free to open (separate) PRs for any/all of
|
Collaborator
Collaborator
rcannood
added a commit
that referenced
this pull request
Sep 4, 2024
* Add neurips2021 dataset loader * add test script * Add process_openproblems_neurips2021_bmmc workflow * Add resource_test script for processing NeurIPS 2021 BMMC dataset * Update predict_modality workflow and resource test script * Update neurips dataset loader * fix predict_modality to work with new data format * update neurips2021_bmmc.sh source path * force ci test * Add test resource file for openproblems_neurips2021_bmmc * download full dataset as tempfile * make fixes to the PM interface --------- Co-authored-by: Robrecht Cannoodt <rcannood@gmail.com>
rcannood
added a commit
that referenced
this pull request
Sep 4, 2024
* Add neurips2021 dataset loader * add test script * Add process_openproblems_neurips2021_bmmc workflow * Add resource_test script for processing NeurIPS 2021 BMMC dataset * Update predict_modality workflow and resource test script * Update neurips dataset loader * fix predict_modality to work with new data format * update neurips2021_bmmc.sh source path * force ci test * Add test resource file for openproblems_neurips2021_bmmc * download full dataset as tempfile * make fixes to the PM interface --------- Co-authored-by: Robrecht Cannoodt <rcannood@gmail.com> Former-commit-id: cef0e51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission type
Testing
Submission guidelines
This is the Spatial decomposition team MVP 💪 @hiraksarkar @almaan none of us really managed to get docker+sagemaker going but we tested locally and CI checks passed in previous PRs.
What we could improve (already in this PR) is:
datasetsandtaskLooking forward to code review!