Skip to content

[CVP-4587] Scale up 4.22 clusterpools#77778

Draft
nmars wants to merge 1 commit intoopenshift:mainfrom
nmars:scale-4-22-pools
Draft

[CVP-4587] Scale up 4.22 clusterpools#77778
nmars wants to merge 1 commit intoopenshift:mainfrom
nmars:scale-4-22-pools

Conversation

@nmars
Copy link
Copy Markdown
Contributor

@nmars nmars commented Apr 14, 2026

Scaled up 4.22 clusterpools for CVP

Summary by CodeRabbit

  • Chores
    • Updated cluster pool capacity configurations for provisioning infrastructure in AWS environments
    • Modified installer settings for image policy handling during cluster deployment processes

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: efac00ef-c123-43b5-b911-bcd76b36c62a

📥 Commits

Reviewing files that changed from the base of the PR and between 4b2b5d4 and 33a2157.

📒 Files selected for processing (2)
  • clusters/hosted-mgmt/hive/pools/cvp/cvp-fips-ocp-4-22-amd64-aws-eu-central-1_clusterpool.yaml
  • clusters/hosted-mgmt/hive/pools/cvp/cvp-ocp-4-22-amd64-aws-eu-central-1_clusterpool.yaml

Walkthrough

Two ClusterPool YAML configurations in the CVP pool directory have been updated to enable experimental image policy disabling via installer environment variables and adjust cluster capacity metrics with different values for FIPS and non-FIPS variants.

Changes

Cohort / File(s) Summary
ClusterPool Capacity & Installer Configuration
clusters/hosted-mgmt/hive/pools/cvp/cvp-fips-ocp-4-22-amd64-aws-eu-central-1_clusterpool.yaml, clusters/hosted-mgmt/hive/pools/cvp/cvp-ocp-4-22-amd64-aws-eu-central-1_clusterpool.yaml
Added installerEnv entry enabling OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY. Updated capacity metrics: FIPS variant sets runningCount and size to 7 and 9 respectively; non-FIPS variant sets both to 5.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Scale up 4.22 clusterpools' accurately reflects the main change—increasing runningCount and size capacity across multiple 4.22 clusterpool configurations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed Pull request contains only Kubernetes YAML configuration files for cluster pools with no Ginkgo test files or test name declarations present.
Test Structure And Quality ✅ Passed PR modifies Kubernetes manifest YAML files for cluster pool configuration, not Ginkgo test code, so quality requirements for tests are not applicable.
Microshift Test Compatibility ✅ Passed This pull request does not add any new Ginkgo e2e tests. The changes consist solely of Kubernetes manifest files (YAML ClusterPool configurations) that adjust OpenShift installer environment variables and pool capacity settings.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only Kubernetes ClusterPool YAML files with infrastructure configuration adjustments; no new Ginkgo e2e test code added, so SNO test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed ClusterPool infrastructure resources define cluster provisioning parameters without pod-level scheduling constraints relevant to topology-aware scheduling.
Ote Binary Stdout Contract ✅ Passed OTE Binary Stdout Contract check does not apply to Kubernetes manifest YAML files, only source code. PR contains only ClusterPool configuration files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests are added; changes are limited to Kubernetes ClusterPool YAML manifests.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from Prucek and psalajova April 14, 2026 12:40
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nmars

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2026
@openshift-merge-bot openshift-merge-bot bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 14, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@nmars: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 14, 2026

@nmars: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nmars nmars marked this pull request as draft April 14, 2026 13:38
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2026
@nmars
Copy link
Copy Markdown
Contributor Author

nmars commented Apr 14, 2026

Hold until #77781 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant