Build hypershift-cli in ci-operator; remove supplemental BC#77781
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughThe changes migrate the hypershift-cli build process from a Kubernetes BuildConfig resource to a ci-operator-based approach. A new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
bot
added
the
approved
|
/pj-rehearse pull-ci-openshift-hypershift-main-images |
|
@deepsm007: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
deepsm007
force-pushed
the
hypershift-cli-ci-postsubmit
branch
from
ada7080 to
552cb25
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Makefile (1)
531-533: Add a preflight check before retagginghypershift-cli:latest.This makes failures clearer when the postsubmit image has not been promoted yet.
Suggested patch
build-hypershift-deployment: TAG ?= $(shell date +%Y%m%d) build-hypershift-deployment: echo "Tagging ci/hypershift-cli snapshot as $(TAG) (built by branch-ci-openshift-hypershift-main-images)." + oc --context app.ci -n ci get istag hypershift-cli:latest >/dev/null oc --context app.ci -n ci --as system:admin tag hypershift-cli:latest hypershift-cli:$(TAG)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Makefile` around lines 531 - 533, Add a preflight check in the build-hypershift-deployment Makefile target to verify the postsubmit image exists before running the retag; use the same oc context/namespace (oc --context app.ci -n ci) to query the imagestreamtag (e.g., check imagestreamtag hypershift-cli:latest with oc get imagestreamtag or istag) and if the resource is missing emit a clear error and exit non‑zero, otherwise proceed to run the existing oc --context app.ci -n ci --as system:admin tag hypershift-cli:latest hypershift-cli:$(TAG).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Makefile`:
- Around line 531-533: Add a preflight check in the build-hypershift-deployment
Makefile target to verify the postsubmit image exists before running the retag;
use the same oc context/namespace (oc --context app.ci -n ci) to query the
imagestreamtag (e.g., check imagestreamtag hypershift-cli:latest with oc get
imagestreamtag or istag) and if the resource is missing emit a clear error and
exit non‑zero, otherwise proceed to run the existing oc --context app.ci -n ci
--as system:admin tag hypershift-cli:latest hypershift-cli:$(TAG).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 7b6ee83f-5c49-4fc2-92be-0180d0f2fafc
📒 Files selected for processing (7)
Makefileci-operator/config/openshift/hypershift/openshift-hypershift-main.yamlci-operator/jobs/openshift-priv/hypershift/openshift-priv-hypershift-main-postsubmits.yamlci-operator/jobs/openshift-priv/hypershift/openshift-priv-hypershift-main-presubmits.yamlci-operator/jobs/openshift/hypershift/openshift-hypershift-main-postsubmits.yamlci-operator/jobs/openshift/hypershift/openshift-hypershift-main-presubmits.yamlclusters/core-ci/supplemental-ci-images/hypershift/hypershift-cli.yaml
💤 Files with no reviewable changes (5)
- ci-operator/jobs/openshift-priv/hypershift/openshift-priv-hypershift-main-presubmits.yaml
- ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-postsubmits.yaml
- ci-operator/jobs/openshift-priv/hypershift/openshift-priv-hypershift-main-postsubmits.yaml
- ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-presubmits.yaml
- clusters/core-ci/supplemental-ci-images/hypershift/hypershift-cli.yaml
deepsm007
force-pushed
the
hypershift-cli-ci-postsubmit
branch
from
552cb25 to
d817d97
Compare
|
/lgtm |
|
[REHEARSALNOTIFIER]
A total of 40 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse ack |
|
@deepsm007: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
bot
added
the
rehearsals-ack
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danilo-gemoli, deepsm007, Prucek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label priority/ci-critical |
openshift-ci
bot
added
the
priority/ci-critical
|
/test app-ci-config-dry |
|
/override ci/build-farm/app-ci-config-dry |
|
@deepsm007: Overrode contexts on behalf of deepsm007: ci/build-farm/app-ci-config-dry DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 50b1004
into
openshift:main
3 participants
Problem
ci/hypershift-cli:latest(QCI:quay.io/openshift/ci:ci_hypershift-cli_latest) was produced by a supplemental BuildConfig (clusters/core-ci/supplemental-ci-images/hypershift/hypershift-cli.yaml) that wrapshypershift/hypershift-operator:latestand installsjq. That path is decoupled in time fromopenshift/hypershiftimage promotion. Downstream jobs (e.g.openshift/ci-toolsimage builds) importpipeline:hypershiftat job start; when QCI tag moves and older manifests are no longer served, pulls by stale digest fail withmanifest unknownonquay-proxy.ci.openshift.org/openshift/ci@sha256:….Building and promoting
hypershift-cliin the sameci-operatorpromotion run ashypershift-operatoraligns the hypershift CLI image with the operator image and uses the normalci-operator→ QCI promotion path (including the intended…_prune_…tag behavior documented around QCI GC — seehack/qci_registry_pruner.py).What this change does
hypershift-cliimage toopenshift/hypershiftmaoinci-operator config:FROM hypershift-operator+yum install -y jq, promoted toci/hypershift-cli:latest(same QCI monorepo tag as today:ci_hypershift-cli_latest).openshift-priv/hypershiftmain.--target=hypershift-clito the images presubmit and postsubmit jobs.hypershift-cliBuildConfig manifest underclusters/core-ci/supplemental-ci-images/hypershift/so core-ci no longer maintains a separate rebuild path./cc @openshift/test-platform
Summary by CodeRabbit
New Features
hypershift-clias a new buildable and promotable image artifact.Chores
hypershift-cliin build and promotion workflows.