bpo-1025395: Fix email.utils.parseaddr to handle multiple hops#142
bpo-1025395: Fix email.utils.parseaddr to handle multiple hops#142ioanatia wants to merge 1 commit intopython:masterfrom
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:
Thanks again to your contribution and we look forward to looking at it! |
ioanatia
force-pushed
the
fix-email-utils-parseaddr
branch
from
350ccc1 to
9804620
Compare
Update the URLs for the documentation (http://stackless.readthedocs.io) and source code browsing (https://github.com/stackless-dev/stackless). (cherry picked from commit b4a5725)
|
Hey folks! I was wondering why my PR keeps failing, even though I did a rebase a couple of days ago! Can someone elucidate what might be going on here, please? From what I'm noticing, the Travis job has a different config than other jobs, so I'm kinda confused about why is that. Thanks a lot! |
|
It's totally fine to just do a merge if that's easier since we will do a squash commit in the end. I've restarted the Travis job just in case it was a weird fluke, though. |
ioanatia
force-pushed
the
fix-email-utils-parseaddr
branch
from
9804620 to
6d17d16
Compare
|
Rebasing the branch on latest master does not fix it. |
|
Maybe try doing a merge instead of a rebase? We've had issues in the past of Travis only grabbing the last 50 commits so that can lead to issues with older PRs. |
Update the URLs for the documentation (http://stackless.readthedocs.io) and source code browsing (https://github.com/stackless-dev/stackless).
|
Thanks for the PR, @ioanatia.
The change seems unrelated to your change, but unless that got fixed we can't accept the PR. I realize this PR is quite old, so it's possible the fix for the failed travis build has already been done.
The instruction for blurb add is here |
Mariatta
left a comment
Mariatta
left a comment
There was a problem hiding this comment.
Please see my review: #142 (comment)
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
ioanatia
force-pushed
the
fix-email-utils-parseaddr
branch
from
8219850 to
4194c66
Compare
Update the URLs for the documentation (http://stackless.readthedocs.io) and source code browsing (https://github.com/stackless-dev/stackless). (cherry picked from commit b4a5725)
Codifies three protocols developed across the emitAnyCall PURE conversion arc (push 56-59) per pythia python#142/python#141/python#143 + supervisor + theologian authorizations: P8 — Phase 0' Coverage Extension to Perf-Regressing Benchmarks Per pythia python#142 python#1 + supervisor 22:46:24Z + 22:47:40Z. Sentinel-only HIR diff has empirical blind spot to single-bench regressions on unrelated workloads (caught when emitAnyCall push 59 showed int_arith -10% with exception-sentinel HIR-diff PASSING). Procedure: identify 24-bench >5% benches, run Phase 0' HIR-diff on bench source per identified bench (precise scrub, structural diff). Add to gate Step 7 post-processing. P9 — Filesystem-First Cross-Check Before Fabrication HALT Per medic 2026-04-22 build-claim false positive + medic 2026-04-25 22:50:53Z PYTHONJITDUMPFINALHIR false positive against generalist HIR dumps that were filesystem-verified at /tmp + retracted at 22:53:44Z. Procedure: identify implied artifact, ls + stat to confirm existence/mtime, post QUERY (not HALT) if artifact exists, never cite session-log absence as sole evidence. Costs ~30s vs ~5-10min false- positive recovery cycle. P10 — Variance Characterization Before (B) Investigation Per W-EMITANYCALL-INT-ARITH-PERF closure 22:57:29Z + pythia python#143 python#1 amendment 23:21:18Z + supervisor 23:21:51Z. Mirrors agent-memory feedback_falsifier_convergent_negative.md (per-agent reasoning side); P10 codifies team-process side. Procedure (7 steps): identify >5% benches, 3-run targeted re-runs for in-isolation variance, AT LEAST ONE full-24-bench re-run for in-context variance (different statistical populations: page-cache, branch-predictor, allocator history, subprocess-position effects). Closure REQUIRES both isolated AND in-context corroboration; if isolated clean but in-context reproduces delta → real signal in sequence-context layer (cold-start/page-cache), not at conversion layer. Pythia python#143 python#4 caught these 3 protocols as 'LANDED in spec but uncommitted at HEAD 0810be4 — exist only in working tree, not yet history.' This commit closes that gap: protocols now in git history before being cited as canonical (CC3 codification-on-authoring rule). Spec doc: P1-P10 + 3 cross-cutting (CC1/CC2/CC3) + paired empirical controls (PhxMem positive / HirType negative). Bundle target: push 60 if Alex authorizes (A)/(B)/(C); separate codification push if Alex direction is delayed >2hr per supervisor 23:21:51Z.
6 participants
This fixes a very old issue with
email.utils.parseaddr.Right now
email.utils.parseaddrwill fail to parse the input correctly when the address contains a route with multiple hops. However it does not have an issue with single hop routes.RFC5322 states that including route hops is obsolete and that the route part should be ignored (Section 4.4). It also states that this syntax is valid and it must be accepted and parsed (Section 4).
https://bugs.python.org/issue1025395