Skip to content

bpo-1025395: Fix email.utils.parseaddr to handle multiple hops #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ioanatia wants to merge 1 commit into from
Closed

bpo-1025395: Fix email.utils.parseaddr to handle multiple hops #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/email/_parseaddr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,8 @@ def getrouteaddr(self):
elif self.field[self.pos] == '@':
self.pos += 1
expectroute = True
elif self.field[self.pos] == ',':
self.pos += 1
elif self.field[self.pos] == ':':
self.pos += 1
else:
Expand Down
6 changes: 6 additions & 0 deletions Lib/test/test_email/test_email.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3141,6 +3141,12 @@ def test_parseaddr_preserves_spaces_in_local_part(self):
self.assertEqual(('', 'merwok.wok.wok@xample.com'),
utils.parseaddr('merwok. wok . wok@xample.com'))

def test_parseaddr_handles_obsolete_addressing(self):
self.assertEqual(('foobar', 'foo@bar.com'),
utils.parseaddr('"foobar" <@hop.org:foo@bar.com>'))
self.assertEqual(('foobar', 'foo@bar.com'),
utils.parseaddr('"foobar" <@hop1.org,@hop2.org:foo@bar.com>'))

def test_formataddr_does_not_quote_parens_in_quoted_string(self):
addr = ("'foo@example.com' (foo@example.com)",
'foo@example.com')
Expand Down