Add support for savestreaming method#53
Closed
rjplevin wants to merge 2 commits intoqueryverse:masterfrom
rjplevin:savestreaming
Closed
Add support for savestreaming method#53rjplevin wants to merge 2 commits intoqueryverse:masterfrom rjplevin:savestreaming
rjplevin wants to merge 2 commits intoqueryverse:masterfrom
rjplevin:savestreaming
Conversation
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 81 86 +5
=====================================
+ Hits 81 86 +5
Continue to review full report at Codecov.
|
Contributor
Author
|
Added tests for savestreaming. Should be good to merge. |
|
@davidanthoff are we good to merge this so I can use it for Mimi? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like it says. Also, might want to use
CSV_or_TSVunion to reduce duplication as I did here.