Add support for savestreaming method, take 2#59
Merged
davidanthoff merged 4 commits intomasterfrom Aug 30, 2019
Merged
Conversation
|
Sure I'll do that this weekend thank you! |
|
@davidanthoff I use a dictionary to keep track of the streams, that was previously initialized as this now causes a type error, is the following correct now? I could probably also just not type parameterize it. |
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
- Coverage 100% 96.73% -3.27%
==========================================
Files 2 2
Lines 81 92 +11
==========================================
+ Hits 81 89 +8
- Misses 0 3 +3
Continue to review full report at Codecov.
|
|
@davidanthoff ok all good you can merge and tag! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #53.
The documentation for the API in FileIO.jl is really incomplete, but I think this PR is how it should be done (I tracked down some packages from the person who initially added this feature to FileIO.jl and looked how they are doing it).
The API from a user point of view is:
@lrennels, can you adapt your code to this new API, test whether things work, and then I'll merge this PR here?