[NONEVM-4759] [TXM] Add expiration check in broadcastLoop before broadcast#720
Conversation
patricios-space
force-pushed
the
txm/fix/dont-broadcast-expired-txs
branch
from
e3dcab7 to
c9b73ff
Compare
There was a problem hiding this comment.
Pull request overview
Adds a pre-broadcast expiration guard to prevent TXM from attempting to send transactions that have already expired while waiting in the broadcast queue.
Changes:
- Check
tx.ExpirationinsidebroadcastLoopbefore constructing/signing/broadcasting the message. - Emit a warning log and skip broadcasting when a queued transaction is expired.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
patricios-space
force-pushed
the
txm/fix/dont-broadcast-expired-txs
branch
from
d703bd4 to
4488709
Compare
patricios-space
changed the base branch from
main
to
txm/fix/classify-insufficient-funds-as-fatal-error-in-broadcastWithRetry
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
patricios-space
requested review from
jadepark-dev,
krebernisak and
vicentevieytes
| txID := "none" | ||
| if tx.ID != nil { | ||
| txID = *tx.ID | ||
| } |
There was a problem hiding this comment.
Hmm, what was this logic for?
There was a problem hiding this comment.
Only for logging none if txID si nil 🤷. I've move id up so I can log it in the filter too
…roadcastWithRetry' into txm/fix/dont-broadcast-expired-txs
NONEVM-4759
Depends on #726