[NONEVM-4760] [TXM] Classify "insufficient funds" as fatal in broadcastWithRetry#726
Open
patricios-space wants to merge 22 commits intotxm/fix/check-rpc-health-and-balance-before-transmitfrom
Conversation
patricios-space
force-pushed
the
txm/fix/classify-insufficient-funds-as-fatal-error-in-broadcastWithRetry
branch
from
701ccdb to
2cdcb4a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the TON TxManager to stop retrying broadcasts when the failure indicates insufficient funds/zero balance, and refactors client usage to an interface so callers no longer access wallet/client fields directly.
Changes:
- Classify a specific “insufficient funds / cannot apply external message …” wallet error as fatal (no retry) in
broadcastWithRetry. - Introduce
SignedAPIClientInterfaceand migrate TXM/relay/CCIP transmitter call sites to useGetClient()/GetWallet(). - Expand TXM integration tests to cover “zero balance” and “insufficient balance” scenarios; add a new tracetracking transfer integration test; fix a docs typo.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/txm/txm.go | Adds fatal classification for insufficient-funds wallet errors; logs when no outgoing messages; migrates to client interface accessors. |
| pkg/ton/tracetracking/signed_api_client.go | Introduces SignedAPIClientInterface; wraps send failures in WalletTXError; adds GetClient/GetWallet. |
| pkg/relay/service.go | Updates relay Tx sending to use GetWallet() accessor. |
| pkg/relay/relay.go | Updates relay TxManager interface to return SignedAPIClientInterface. |
| pkg/relay/chain.go | Updates lazy client provider to return SignedAPIClientInterface and uses GetClient(). |
| pkg/ccip/ocr/contract_transmitter.go | Updates transmitter to use GetWallet() accessor. |
| integration-tests/txm/txm_test.go | Refactors/extends TXM integration tests; adds insufficient-funds coverage and log assertions. |
| integration-tests/tracetracking/transfer_test.go | Adds a new integration test around transfer/fees behavior. |
| docs/contracts/overview/ccip/offramp/arbitrary-msg.md | Fixes “transmiter” → “transmitter” typo in diagram note. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
patricios-space
force-pushed
the
txm/fix/classify-insufficient-funds-as-fatal-error-in-broadcastWithRetry
branch
from
24e599b to
f9a1cd8
Compare
patricios-space
changed the base branch from
main
to
txm/fix/check-rpc-health-and-balance-before-transmit
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
patricios-space
force-pushed
the
txm/fix/classify-insufficient-funds-as-fatal-error-in-broadcastWithRetry
branch
from
7bff969 to
1e769fd
Compare
| GetWallet() *wallet.Wallet | ||
| } | ||
|
|
||
| var _ SignedAPIClientInterface = (*SignedAPIClient)(nil) |
Collaborator
There was a problem hiding this comment.
nit: I can see you're trying to avoid duplication but adding interface suffix seems redundant
Collaborator
Author
There was a problem hiding this comment.
I know, I haven't think of a better name yet. I could hide the struct as private, but tracetracking.SignedAPIClient has 43 uses in integration-tests and pkg has 10. I wanted to keep this fix contained instead of changing so many files.
…nto txm/fix/classify-insufficient-funds-as-fatal-error-in-broadcastWithRetry
… of SignedAPIClient Revert "ref: migrate txm to Interface" This reverts commit cb1394b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NONEVM-4760
Depends on #721