Conversation
📝 WalkthroughWalkthroughThis PR refactors the CI/CD pipeline by introducing dedicated build workflows for Docker and npm packages. Rather than building during publish, new workflows generate artifacts that downstream publish workflows consume, enabling reusable, decoupled build processes invoked through the release workflow. Changes
Sequence DiagramsequenceDiagram
actor Trigger
participant Release as release.yml
participant BuildWasm as build-wasm.yml
participant BuildDocker as build-docker.yml
participant Artifacts as Artifact Storage
participant PublishNpm as publish-npm.yml
participant PublishDocker as publish-docker.yml
Trigger->>Release: Manual / Push event
Release->>Release: Evaluate plan condition
Release->>BuildWasm: Call workflow<br/>(if plan eligible)
Release->>BuildDocker: Call workflow<br/>(if plan eligible)
par Build Artifacts
BuildWasm->>BuildWasm: Checkout + Setup Rust
BuildWasm->>BuildWasm: Build wasm package
BuildWasm->>Artifacts: Upload npm-package artifact
BuildDocker->>BuildDocker: Checkout repo
BuildDocker->>Artifacts: Upload docker-context artifact
end
Release->>PublishNpm: Wait on build jobs
Release->>PublishDocker: Wait on build jobs
par Publish from Artifacts
PublishNpm->>Artifacts: Download npm-package artifact
PublishNpm->>PublishNpm: npm publish
PublishDocker->>Artifacts: Download docker-context artifact
PublishDocker->>PublishDocker: docker buildx build --push
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.github/workflows/build-docker.yml (1)
10-13: Consider makingplaninput optional or documenting its unused status.The
planinput is declared asrequired: truebut is not used anywhere in this workflow. While this maintains consistency with other build workflows (likebuild-wasm.yml) and allows uniform invocation fromrelease.yml, it may cause confusion. Consider either:
- Making it optional:
required: false- Adding a comment explaining it's for interface consistency with other build jobs
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/build-docker.yml around lines 10 - 13, The workflow declares an inputs.plan parameter as required: true but it isn't used; update the inputs.plan declaration (inputs.plan) to either make it optional by changing required: true to required: false, or add a clear inline comment next to the inputs.plan entry explaining that it is intentionally kept for interface consistency with other build workflows (e.g., build-wasm.yml) and for uniform invocation from release.yml so callers understand why it exists..github/workflows/release.yml (1)
249-253: Theifcondition is correct but growing unwieldy.The extended condition properly gates the
hostjob on all build stages completing successfully or being skipped. While functionally correct, this single-line condition is becoming difficult to read and maintain.Consider extracting to a reusable expression or restructuring as a matrix/needs check in a future refactor, though this is not blocking for this PR.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/release.yml around lines 249 - 253, The long if condition on the host job (checking needs.plan, needs.build-global-artifacts, needs.build-local-artifacts, needs.custom-build-binaries, needs.custom-build-wasm, needs.custom-build-docker) is correct but hard to read — extract it into a reusable YAML anchor or single named string and reference that anchor/name from the host job's if to improve readability and maintainability; create an anchor like &builds_ok_if with the full expression and replace the inline if with *builds_ok_if (or put the expression into a single variable/constant and reference that variable) so the condition logic remains identical but is easier to manage.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/build-wasm.yml:
- Around line 23-26: Update the GitHub Actions step that references
actions-rust-lang/setup-rust-toolchain by bumping its version from v1.11.0 to
v1.15.4; keep the existing with: target: wasm32-unknown-unknown configuration
and leave the jetli/wasm-pack-action@v0.4.0 step unchanged so the workflow
benefits from the newer Rust toolchain action fixes.
---
Nitpick comments:
In @.github/workflows/build-docker.yml:
- Around line 10-13: The workflow declares an inputs.plan parameter as required:
true but it isn't used; update the inputs.plan declaration (inputs.plan) to
either make it optional by changing required: true to required: false, or add a
clear inline comment next to the inputs.plan entry explaining that it is
intentionally kept for interface consistency with other build workflows (e.g.,
build-wasm.yml) and for uniform invocation from release.yml so callers
understand why it exists.
In @.github/workflows/release.yml:
- Around line 249-253: The long if condition on the host job (checking
needs.plan, needs.build-global-artifacts, needs.build-local-artifacts,
needs.custom-build-binaries, needs.custom-build-wasm, needs.custom-build-docker)
is correct but hard to read — extract it into a reusable YAML anchor or single
named string and reference that anchor/name from the host job's if to improve
readability and maintainability; create an anchor like &builds_ok_if with the
full expression and replace the inline if with *builds_ok_if (or put the
expression into a single variable/constant and reference that variable) so the
condition logic remains identical but is easier to manage.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c4b81031-ca7a-4de7-9714-8915ceb7a009
📒 Files selected for processing (6)
.github/workflows/build-docker.yml.github/workflows/build-wasm.yml.github/workflows/publish-docker.yml.github/workflows/publish-npm.yml.github/workflows/release.ymldist-workspace.toml
Comment on lines
+23
to
+26
| - uses: actions-rust-lang/setup-rust-toolchain@v1.11.0 | ||
| with: | ||
| target: wasm32-unknown-unknown | ||
| - uses: jetli/wasm-pack-action@v0.4.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
What is the latest version of jetli/wasm-pack-action GitHub Action?
💡 Result:
The latest version of the jetli/wasm-pack-action GitHub Action is v0.4.0.
Citations:
- 1: https://github.com/jetli/wasm-pack-action/releases
- 2: https://github.com/jetli/wasm-pack-action
- 3: https://github.com/marketplace/actions/wasm-pack-action
🌐 Web query:
What is the latest version of actions-rust-lang/setup-rust-toolchain GitHub Action?
💡 Result:
The latest version of the actions-rust-lang/setup-rust-toolchain GitHub Action is v1.15.4, released on March 14, 2026.
Citations:
- 1: https://github.com/actions-rust-lang/setup-rust-toolchain
- 2: https://github.com/actions-rust-lang/setup-rust-toolchain/releases
- 3: https://github.com/actions-rust-lang/setup-rust-toolchain/blob/main/CHANGELOG.md
Update actions-rust-lang/setup-rust-toolchain to v1.15.4.
The workflow uses actions-rust-lang/setup-rust-toolchain@v1.11.0, which is outdated. The latest version is v1.15.4 (released March 14, 2026). Meanwhile, jetli/wasm-pack-action@v0.4.0 is already at the latest version. Update the Rust toolchain action to benefit from recent bug fixes and improvements.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/build-wasm.yml around lines 23 - 26, Update the GitHub
Actions step that references actions-rust-lang/setup-rust-toolchain by bumping
its version from v1.11.0 to v1.15.4; keep the existing with: target:
wasm32-unknown-unknown configuration and leave the jetli/wasm-pack-action@v0.4.0
step unchanged so the workflow benefits from the newer Rust toolchain action
fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit