Skip to content
This repository was archived by the owner on Sep 2, 2021. It is now read-only.

[Mac] Accept folder dropped on shell icon#353

Merged
RaymondLim merged 1 commit intoadobe:masterfrom
eugeneo:folderdrag
Oct 22, 2013
Merged

[Mac] Accept folder dropped on shell icon#353
RaymondLim merged 1 commit intoadobe:masterfrom
eugeneo:folderdrag

Conversation

@eugeneo
Copy link
Copy Markdown
Contributor

@eugeneo eugeneo commented Oct 11, 2013

I don't have a JS-side implementation yet - this simply enables the Dock icon feedback and passes the path to openFile in application delegate. JS code currently merrily reports an error. I also plan to take a look at JS code.

@RaymondLim
Copy link
Copy Markdown
Contributor

@eugeneo Thanks for working on this. I tested with your change, and it does allow folder drop on the icon (both on the dock icon and on the desktop alias icon). Before I can merge your pull request, you need to sign up CLA here.

@eugeneo
Copy link
Copy Markdown
Contributor Author

eugeneo commented Oct 20, 2013

@RaymondLim Done.

@RaymondLim
Copy link
Copy Markdown
Contributor

Merging now since we've already landed all other necessary changes to go with this pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants