This repository was archived by the owner on Sep 6, 2021. It is now read-only.
[Mac] Open folder dropped on a Dock icon#5496
Closed
eugeneo wants to merge 1 commit intoadobe:masterfrom
eugeneo:folderdrag
Closed
[Mac] Open folder dropped on a Dock icon#5496eugeneo wants to merge 1 commit intoadobe:masterfrom eugeneo:folderdrag
eugeneo wants to merge 1 commit intoadobe:masterfrom
eugeneo:folderdrag
Conversation
ghost
assigned
Author
|
Noticed there's a bug for this issue - #5015 |
Contributor
|
@eugeneo Thanks for your simple solution. But we would like to consolidate this with our drag-and-drop code that already handles files/folder dropped inside the editor window to provide consistent behavior. So we won't be taking this pull request. Feel free to review my pull requests #5590 and adobe/brackets-shell#361, and put any comment you may have. One major difference with your pull request is that we don't open any project when the user drops more than one folder or together with other files. |
Contributor
|
Closing as we don't need this anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires following pull request in brackets-shell: adobe/brackets-shell#353