This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Conversation
…der drop on Brackets app.
ghost
assigned
Contributor
|
Done with initial review. Looks pretty straightforward. @RaymondLim Was there another pull request (ie. in the shell) that you needed me to review along with this one? |
Contributor
Author
|
@bchintx I'm still working on another pull request that also needs to fix #5586. But you can merge this one without causing any issue though. If you would like to review the upcoming pull request, then you can use rlim/handle-dropped-folder branch in brackets-shell repo. I had mac specific changes done in that branch. That branch also requires pr adobe/brackets-shell#353. |
This was referenced Oct 22, 2013
Contributor
|
Looks good. Merging... |
bchintx
added a commit
that referenced
this pull request
Oct 22, 2013
Create a new command file.openDroppedFiles so that we can support folder drop on Brackets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is to consolidate different code that handle the drag and drop of files and folders by creating a new command for openDroppedFiles in DragAndDrop.js and calling it for all drag-and-drop triggered from the shell code. So it is part of the fix for issue #5015. There are two more pull requests from brackets-shell to complement this.