This repository was archived by the owner on Jul 13, 2025. It is now read-only.
Changes to compile against gax-httpjson#1659
Merged
garrettjonesgoogle merged 12 commits intogoogleapis:masterfrom Nov 1, 2017
Merged
Changes to compile against gax-httpjson#1659garrettjonesgoogle merged 12 commits intogoogleapis:masterfrom
garrettjonesgoogle merged 12 commits intogoogleapis:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1659 +/- ##
===========================================
- Coverage 85.53% 85.5% -0.03%
- Complexity 4286 4289 +3
===========================================
Files 405 405
Lines 16842 16853 +11
Branches 1762 1763 +1
===========================================
+ Hits 14405 14410 +5
- Misses 1849 1855 +6
Partials 588 588
Continue to review full report at Codecov.
|
andreamlin
reviewed
Oct 26, 2017
| @@ -274,11 +274,7 @@ public GapicMethodConfig getMethodConfig(Method method) { | |||
| } | |||
|
|
|||
| public GapicMethodConfig getMethodConfig(String methodSimpleName, String fullName) { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| } else if (methodConfig.isBatching()) { | ||
| callableImplType = ApiCallableImplType.BatchingApiCallable; | ||
| } else if (methodConfig.isLongRunningOperation()) { | ||
| callableImplType = ApiCallableImplType.InitialOperationApiCallable; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| */ | ||
| public static class Builder extends ClientSettings.Builder { | ||
| private final ImmutableList<UnaryCallSettings.Builder> unaryMethodSettingsBuilders; | ||
| private final ImmutableList<UnaryCallSettings.Builder<?, ?>> unaryMethodSettingsBuilders; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
Addressed feedback, PTAL |
Contributor
Author
|
I made an update because I missed a few create() -> of() renames, PTAL |
garrettjonesgoogle
force-pushed
the
gax-httpjson
branch
from
fb7b208 to
51b0cbb
Compare
igorbernstein2
added a commit
to igorbernstein2/artman
that referenced
this pull request
Nov 3, 2017
Toolkit recently had a breaking change: googleapis/gapic-generator#1659 And all of the clients in google-cloud-java were regenerated: googleapis/google-cloud-java#2564
evaogbe
pushed a commit
to evaogbe/toolkit
that referenced
this pull request
Nov 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.