[iOS, macOS] Fixed CollectionView KeepLastItemInView Not Updating Correctly When Items Are Added Dynamically#32191
Merged
kubaflo merged 11 commits intodotnet:inflight/currentfrom Mar 30, 2026
Conversation
dotnet-policy-service
Bot
added
the
partner/syncfusion
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where KeepLastItemInView in CollectionView does not properly maintain the last item in view when items are dynamically added on iOS and macOS. The root cause was that the ItemsUpdatingScrollMode field in the internal LayoutFactory2 class was not being updated when the property changed at runtime.
Key changes:
- Added a public method
UpdateItemsUpdatingScrollModeto dynamically update the scroll mode in the layout - Changed
CustomUICollectionViewCompositionalLayoutclass visibility fromprivatetointernalto enable access from the mapper - Modified the iOS mapper to call the new update method when
ItemsUpdatingScrollModechanges
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/Controls/src/Core/Handlers/Items2/iOS/LayoutFactory2.cs | Changed class visibility to internal and added public method to update scroll mode |
| src/Controls/src/Core/Handlers/Items2/ItemsViewHandler2.iOS.cs | Updated mapper to call the new update method when scroll mode changes |
| src/Controls/tests/TestCases.HostApp/Issues/Issue31825.cs | Added UI test page demonstrating the fix with a CollectionView that dynamically updates scroll mode |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31825.cs | Added automated test to verify the scroll mode update behavior |
| } | ||
| #nullable enable | ||
| class CustomUICollectionViewCompositionalLayout : UICollectionViewCompositionalLayout | ||
| internal class CustomUICollectionViewCompositionalLayout : UICollectionViewCompositionalLayout |
There was a problem hiding this comment.
Changing the visibility of CustomUICollectionViewCompositionalLayout from private to internal is a breaking change to the internal API surface. While this is not a public API change, this modification should be highlighted for reviewers as it affects the accessibility of this class within the assembly.
| FontSize = 18, | ||
| }; | ||
| nameLabel.SetBinding(Label.TextProperty, "Name"); | ||
| nameLabel.SetBinding(Label.AutomationIdProperty, "Name"); |
There was a problem hiding this comment.
Multiple elements are binding their AutomationId to data properties (Name, Location, Details, ImageUrl), which will result in non-unique AutomationIds when multiple items exist in the CollectionView. This violates the requirement that AutomationIds must be UNIQUE. Only the monkey name 'Gelada' is used in the test, so consider setting a static, unique AutomationId only on the name label, or ensure each AutomationId includes an index or other unique identifier.
| FontSize = 14, | ||
| }; | ||
| locationLabel.SetBinding(Label.TextProperty, "Location"); | ||
| locationLabel.SetBinding(Label.AutomationIdProperty, "Location"); |
There was a problem hiding this comment.
Multiple elements are binding their AutomationId to data properties (Name, Location, Details, ImageUrl), which will result in non-unique AutomationIds when multiple items exist in the CollectionView. This violates the requirement that AutomationIds must be UNIQUE. Only the monkey name 'Gelada' is used in the test, so consider setting a static, unique AutomationId only on the name label, or ensure each AutomationId includes an index or other unique identifier.
| FontSize = 12, | ||
| }; | ||
| detailsLabel.SetBinding(Label.TextProperty, "Details"); | ||
| detailsLabel.SetBinding(Label.AutomationIdProperty, "Details"); |
There was a problem hiding this comment.
Multiple elements are binding their AutomationId to data properties (Name, Location, Details, ImageUrl), which will result in non-unique AutomationIds when multiple items exist in the CollectionView. This violates the requirement that AutomationIds must be UNIQUE. Only the monkey name 'Gelada' is used in the test, so consider setting a static, unique AutomationId only on the name label, or ensure each AutomationId includes an index or other unique identifier.
| }; | ||
|
|
||
| image.SetBinding(Image.SourceProperty, "ImageUrl"); | ||
| image.SetBinding(Image.AutomationIdProperty, "ImageUrl"); |
There was a problem hiding this comment.
Multiple elements are binding their AutomationId to data properties (Name, Location, Details, ImageUrl), which will result in non-unique AutomationIds when multiple items exist in the CollectionView. This violates the requirement that AutomationIds must be UNIQUE. Only the monkey name 'Gelada' is used in the test, so consider setting a static, unique AutomationId only on the name label, or ensure each AutomationId includes an index or other unique identifier.
NanthiniMahalingam
changed the title
jsuarezruiz
suggested changes
Oct 24, 2025
| public override string Issue => "[iOS, macOS]CollectionView KeepLastItemInView not updating correctly when items are added"; | ||
| [Test] | ||
| [Category(UITestCategories.CollectionView)] | ||
| public async Task UpdateItemScrollModeDynamically() |
Contributor
There was a problem hiding this comment.
The test is failing on Android:
at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2566
at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 745
at Microsoft.Maui.TestCases.Tests.Issues.Issue31825.UpdateItemScrollModeDynamically() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31825.cs:line 19
at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.BlockUntilCompleted()
at NUnit.Framework.Internal.MessagePumpStrategy.NoMessagePumpStrategy.WaitForCompletion(AwaitAdapter awaiter)
at NUnit.Framework.Internal.AsyncToSyncAdapter.Await[TResult](Func`1 invoke)
at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)
Contributor
Author
There was a problem hiding this comment.
The test is failing on Android:
at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2566 at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 745 at Microsoft.Maui.TestCases.Tests.Issues.Issue31825.UpdateItemScrollModeDynamically() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31825.cs:line 19 at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.BlockUntilCompleted() at NUnit.Framework.Internal.MessagePumpStrategy.NoMessagePumpStrategy.WaitForCompletion(AwaitAdapter awaiter) at NUnit.Framework.Internal.AsyncToSyncAdapter.Await[TResult](Func`1 invoke) at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context) at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)
Hi @jsuarezruiz ,
I have addressed the failed test case, and it is now passing successfully.
jsuarezruiz
added
platform/ios
area-controls-collectionview
NanthiniMahalingam
changed the title
NanthiniMahalingam
force-pushed
the
Fix-31825
branch
from
05cb8ff to
4a9fb00
Compare
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://github.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 32191Or
iex "& { $(irm https://github.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 32191" |
Contributor
|
/rebase |
github-actions
Bot
force-pushed
the
Fix-31825
branch
from
fb1e011 to
1885d14
Compare
Member
🤖 AI Summary📊 Expand Full Review🔍 Pre-Flight — Context & Validation📝 Review Session — Added required code section. ·
|
| # | Source | Approach | Test Result | Files Changed | Notes |
|---|---|---|---|---|---|
| PR | PR #32191 | Add public UpdateItemsUpdatingScrollMode method to LayoutFactory2; change class visibility to internal; call update method from iOS mapper | ⏳ PENDING (Gate) | ItemsViewHandler2.iOS.cs (+5), LayoutFactory2.cs (+6/-1) |
Original PR. Validates on iOS/macOS. Android test previously failed but claimed fixed. |
Platforms for Testing
- Affected: iOS, macOS
- Available on macOS host: iOS ✅, MacCatalyst ✅, Android ✅
- Selected for Gate: iOS (directly affected, specified by user)
🚦 Gate — Test Verification
📝 Review Session — Added required code section. · 1885d14
Result: ✅ PASSED
Platform: ios
Mode: Full Verification
Verification Details
- Tests FAIL without fix: ✅ Confirmed (bug is present)
- Tests PASS with fix: ✅ Confirmed (fix resolves the issue)
Fix Files Verified
src/Controls/src/Core/Handlers/Items2/ItemsViewHandler2.iOS.cssrc/Controls/src/Core/Handlers/Items2/iOS/LayoutFactory2.cseng/pipelines/common/provision.yml(unrelated changes)eng/pipelines/common/variables.yml(unrelated changes)
Test Behavior
The test correctly:
- Detects the issue when fix is not applied (FAIL without fix)
- Passes when the fix is applied (PASS with fix)
This confirms the test suite properly validates the fix for Issue #31825 - KeepLastItemInView not updating correctly when items are added dynamically.
🔧 Fix — Analysis & Comparison
📝 Review Session — Added required code section. · 1885d14
Fix Candidates
| # | Source | Approach | Test Result | Files Changed | Notes |
|---|---|---|---|---|---|
| 1 | try-fix (claude-sonnet-4.5) | Direct ItemsLayout Property Read - Store ItemsLayout reference in layout, read ItemsUpdatingScrollMode directly instead of caching | ✅ PASS | 1 file (LayoutFactory2.cs) |
Simpler: No new public API, no sync method, class stays private, always consistent |
| PR | PR #32191 | Add public UpdateItemsUpdatingScrollMode method to LayoutFactory2; change class visibility to internal; call update method from iOS mapper | ✅ PASS (Gate) | 2 files (ItemsViewHandler2.iOS.cs +5, LayoutFactory2.cs +6/-1) |
Original PR. Requires public API, class visibility change, manual sync |
Cross-Pollination
Status: Not completed (environment blocker - git cleanup hung indefinitely)
Blocker: After Attempt 1 completed successfully, git cleanup commands (git checkout HEAD -- .) hung indefinitely without output. Attempted once as per SHARED-RULES.md, then proceeded to Report per autonomous execution guidance.
Analysis
Attempt 1 (claude-sonnet-4.5) - ✅ PASSED:
- Approach: Instead of caching
ItemsUpdatingScrollModein a field that requires manual synchronization, store a reference to the entireItemsLayoutobject. Read the currentItemsUpdatingScrollModevalue directly from_itemsLayout?.ItemsUpdatingScrollModewhen needed inFinalizeCollectionViewUpdates. - Why it works: Eliminates synchronization problem by reading directly from source of truth (ItemsLayout) rather than maintaining a cached copy that can get stale
- Advantages over PR:
- Simpler code - no new public API, no synchronization logic
- Always consistent - can't get out of sync because there's no cache
- Better encapsulation - class stays private, no exposure to handler layer
- Less maintenance - fewer moving parts means fewer potential bugs
- Files:
LayoutFactory2.csonly (vs PR's 2 files)
Comparison: PR Fix vs Attempt 1
| Aspect | PR's Fix | Attempt 1 |
|---|---|---|
| Approach | Add public sync method | Store ItemsLayout reference |
| Class visibility | Changed to internal |
Stays private |
| API surface | +1 public method | No new methods |
| Files changed | 2 files | 1 file |
| Consistency | Manual sync required | Always reads current value |
| Complexity | Higher (sync method + mapper call) | Lower (direct property read) |
Exhausted: No - Stopped after 1 successful attempt due to environment blocker (git cleanup hung)
Selected Fix: Attempt 1 (try-fix candidate)
Reasoning:
- Both pass tests - Attempt 1 and PR both achieve the goal
- Simpler solution - Attempt 1 requires fewer code changes (1 file vs 2), no new public API, no class visibility change
- More robust - No manual synchronization means no risk of getting out of sync
- Better encapsulation - Class stays private, follows existing architecture
- Lower maintenance burden - Fewer moving parts, simpler to understand
The PR's fix works correctly but introduces unnecessary complexity. Attempt 1 achieves the same goal more elegantly by eliminating the synchronization problem rather than adding machinery to manage it.
📋 Report — Final Recommendation
📝 Review Session — Added required code section. · 1885d14
⚠️ Final Recommendation: REQUEST CHANGES
Summary
PR #32191 successfully fixes the CollectionView KeepLastItemInView bug, but a simpler alternative approach was found during exploration that achieves the same goal with less complexity.
Key findings:
- ✅ Gate PASSED - Tests correctly fail without fix, pass with fix
- ✅ PR's fix works correctly and passes all tests
⚠️ Alternative fix found with better design characteristics- 🛑 Environment blocker prevented exhaustive exploration (git cleanup hung)
Root Cause
When ItemsUpdatingScrollMode is changed at runtime, the private __itemsUpdatingScrollMode field in the LayoutFactory2.CustomUICollectionViewCompositionalLayout class was not being updated. This prevented ForceScrollToLastItem() from being invoked in FinalizeCollectionViewUpdates(), causing the CollectionView to not scroll to the last item when new items were added with KeepLastItemInView mode.
Why the regression occurred: The field was set once during layout creation but never updated when the property changed dynamically. This is a state synchronization problem.
Fix Comparison
| Aspect | PR's Fix | Alternative (try-fix #1) |
|---|---|---|
| Approach | Add public UpdateItemsUpdatingScrollMode() method |
Store ItemsLayout reference, read property directly |
| Class visibility | Changed to internal |
Stays private ✅ |
| API surface | +1 public method |
No new methods ✅ |
| Files changed | 2 files | 1 file ✅ |
| Synchronization | Manual (mapper calls update method) |
Automatic (reads current value) ✅ |
| Complexity | Higher (sync method + mapper call) | Lower (direct property read) ✅ |
| Test result | ✅ PASS (Gate) | ✅ PASS (try-fix) |
Platform Comparison
Affected platforms: iOS, macOS (regression in .NET 10 Preview 1)
PR approach:
- Changes
CustomUICollectionViewCompositionalLayoutfromprivatetointernal - Exposes internal API to handler layer
- Requires mapper to call sync method when property changes
Alternative approach:
- Keeps class
private(better encapsulation) - No API exposure to handler layer
- Automatically sees current value (no sync needed)
Both approaches work correctly on iOS/macOS. The alternative is architecturally cleaner.
Recommended Changes
Suggested approach: Replace PR's fix with the simpler alternative.
Changes needed:
File: src/Controls/src/Core/Handlers/Items2/iOS/LayoutFactory2.cs
What to change:
- Instead of adding a public
UpdateItemsUpdatingScrollMode(ItemsUpdatingScrollMode)method, store the entireItemsLayoutreference - Instead of passing
ItemsUpdatingScrollModevalue to constructor, pass theItemsLayoutobject - Instead of caching the value in
_itemsUpdatingScrollModefield, read directly from_itemsLayout?.ItemsUpdatingScrollModewhen needed - Keep the class
private(don't change tointernal)
Remove from: src/Controls/src/Core/Handlers/Items2/ItemsViewHandler2.iOS.cs
- Remove the mapper code that calls
UpdateItemsUpdatingScrollMode()
Why this is better:
- Simpler code - No new public API, no synchronization logic to maintain
- Always consistent - Can't get out of sync because there's no cached value
- Better encapsulation - Class stays private, no exposure to handler layer
- Lower maintenance - Fewer moving parts means fewer potential bugs
- Same functionality - Achieves identical behavior with less complexity
Code Quality Assessment
PR's implementation:
- ✅ Well-tested (includes UI test and automated test)
- ✅ Clear root cause explanation
- ✅ Proper null checking
⚠️ Adds unnecessary API surface (public method + internal class)⚠️ Requires manual synchronization (coupling between handler and layout)
Alternative implementation:
- ✅ All benefits above, plus:
- ✅ No new public API
- ✅ Better encapsulation (private class)
- ✅ Automatic synchronization (no coupling)
- ✅ Single file change
Title & Description
Title: ✅ Accurate - "[iOS, macOS] Fixed CollectionView KeepLastItemInView Not Updating Correctly When Items Are Added Dynamically"
Description: ✅ Well-structured with clear sections, root cause, and testing details. No changes needed.
Edge Cases Reviewed
From reviewer feedback:
- ✅ Non-unique AutomationIds noted by Copilot reviewer - test still works but could be improved
- ✅ Android test failure fixed by author (confirmed in comments)
- ✅ Dynamic scroll mode switching tested
Alternative Implementation Applied
I've applied the simpler alternative fix locally. The changes are ready for review:
- Modified
LayoutFactory2.csto storeItemsLayoutreference and read property directly - Removed synchronization code from
ItemsViewHandler2.iOS.cs(no longer needed) - Tests pass with the alternative approach
Next steps:
- Review the applied changes
- Commit and push to update the PR with the simpler approach
- Or keep the PR's original fix if you prefer the explicit synchronization pattern
Justification for REQUEST CHANGES
While the PR's fix is functionally correct and well-tested, the alternative approach found during exploration is objectively simpler and better aligned with software engineering principles:
- Simplicity - Fewer lines of code, fewer files changed
- Maintainability - No synchronization logic to maintain
- Encapsulation - Keeps internal class private
- Robustness - Can't get out of sync
This meets the criteria for requesting changes per the PR agent workflow: "try-fix found a simpler/better alternative → Request changes with suggestion."
📋 Expand PR Finalization Review
Title: ✅ Good
Current: [iOS, macOS] Fixed CollectionView KeepLastItemInView Not Updating Correctly When Items Are Added Dynamically
Description: ✅ Excellent
Description needs updates. See details below.
Code Review: ⚠️ Issues Found
Code Review for PR #32191
Overview
This PR fixes a bug where ItemsUpdatingScrollMode.KeepLastItemInView doesn't work correctly when the property is changed dynamically after the CollectionView is already rendered.
Files Changed:
ItemsViewHandler2.iOS.cs- Mapper method enhanced to update layoutLayoutFactory2.cs- Class visibility changed, update method addedIssue31825.cs(HostApp) - Test page for reproductionIssue31825.cs(Tests) - Appium UI test
✅ Positive Findings
1. Minimal, Surgical Fix
- The fix is focused and minimal - only adds the necessary code to propagate the property change
- No unnecessary refactoring or scope creep
- Good engineering practice: solve the specific problem without over-engineering
2. Proper Encapsulation
- New public method
UpdateItemsUpdatingScrollModeadded toCustomUICollectionViewCompositionalLayout - Method provides controlled access to update the private field
__itemsUpdatingScrollMode - Better than making the field public or removing encapsulation
3. Appropriate Visibility Change
- Changing
CustomUICollectionViewCompositionalLayoutfromprivatetointernalis justified - The class needs to be accessed from the mapper in
ItemsViewHandler2.iOS.cs internalis the correct visibility level (notpublic) - keeps it package-private
4. Good Test Coverage
- UI test added that reproduces the issue
- Test verifies the fix by:
- Setting
ItemsUpdatingScrollModedynamically - Adding items
- Verifying the last item "Gelada" is visible
- Setting
- Test is simple and focused on the bug scenario
5. Helpful Comment
// When the CollectionView's ItemsUpdatingScrollMode value changes dynamically,
// update the items layout's ItemsUpdatingScrollMode property accordingly.- Comment explains why the code exists (dynamic property changes)
- Helps future maintainers understand the intent
🟡 Suggestions (Non-Blocking)
1. Consider Null-Safety Pattern Consistency
Current code:
if (handler.Controller?.CollectionView?.CollectionViewLayout is LayoutFactory2.CustomUICollectionViewCompositionalLayout customLayout)
{
customLayout.UpdateItemsUpdatingScrollMode(itemsView.ItemsUpdatingScrollMode);
}Observation:
- Uses safe navigation operator (
?.) which is good - Pattern matching with
isprovides null safety for the cast - This is a safe, idiomatic C# pattern
Suggestion (very minor):
- Consider if there are scenarios where
CollectionViewLayoutcould be null or a different type - The current code handles this correctly - no changes needed
Verdict: ✅ Code is correct as-is. No action needed.
2. Test Could Verify Scroll Position (Enhancement)
Current test:
App.WaitForElement("Gelada");What it does:
- Waits for the "Gelada" item to be visible
- This proves the last item is in view
Potential enhancement:
- Could check scroll position or viewport bounds to verify the item is actually at the bottom
- Current test is sufficient for the bug report, but more explicit verification could prevent regressions
Example enhancement:
var gelada = App.WaitForElement("Gelada");
var viewport = App.WaitForElement("CollectionView2").GetRect();
var geladaRect = gelada.GetRect();
// Verify Gelada is near the bottom of viewport
Assert.That(geladaRect.Bottom, Is.LessThanOrEqualTo(viewport.Bottom));Verdict: Current test is acceptable. Enhancement is optional and can be done in future if flakiness occurs.
3. Consider Adding XML Documentation
Current:
public void UpdateItemsUpdatingScrollMode(ItemsUpdatingScrollMode itemsUpdatingScrollMode)
{
_itemsUpdatingScrollMode = itemsUpdatingScrollMode;
}Suggestion:
/// <summary>
/// Updates the items updating scroll mode dynamically.
/// </summary>
/// <param name="itemsUpdatingScrollMode">The new scroll mode to apply.</param>
/// <remarks>
/// This method is used to synchronize the layout's scroll mode when the
/// CollectionView's ItemsUpdatingScrollMode property changes after the
/// CollectionView has already been rendered.
/// </remarks>
public void UpdateItemsUpdatingScrollMode(ItemsUpdatingScrollMode itemsUpdatingScrollMode)
{
_itemsUpdatingScrollMode = itemsUpdatingScrollMode;
}Verdict: Optional improvement. The inline comment in the mapper is sufficient for understanding the intent.
🔍 Architecture Review
Layering and Responsibilities
Question: Is the mapper the right place for this logic?
Analysis:
- ✅ Yes -
MapItemsUpdatingScrollModeis the mapper method that runs whenItemsUpdatingScrollModeproperty changes - ✅ The mapper already updates
itemsLayout.ItemsUpdatingScrollMode - ✅ Adding the layout update in the same location is consistent and logical
- ✅ Alternative would be to hook into property change notification in the layout itself, but that's more complex
Verdict: ✅ Placement is appropriate.
Items2/ Handler Usage
Context: This PR modifies files in src/Controls/src/Core/Handlers/Items2/
From .github/instructions/collectionview-handler-detection.instructions.md:
- Items2/ is the active handler for iOS/MacCatalyst
- Items/ is deprecated for iOS/MacCatalyst
- This PR correctly works on Items2/ since it's iOS/macOS specific
Verdict: ✅ Correct handler directory for iOS/macOS.
🔴 Critical Issues
None found. The code is safe, correct, and ready for merge.
Summary
Code Quality: ✅ Excellent
Strengths:
- Minimal, focused fix
- Proper encapsulation with public method
- Appropriate visibility change (internal)
- Good test coverage
- Helpful comments
No blocking issues found.
Recommendations:
- ✅ Merge as-is - Code is production-ready
- 🟡 Optional: Consider XML docs for the public method (future enhancement)
- 🟡 Optional: Consider enhanced scroll position verification in test (future enhancement)
Final Verdict
✅ APPROVED FOR MERGE
This PR demonstrates good engineering practices:
- Solves the specific problem without over-engineering
- Maintains encapsulation and proper visibility levels
- Includes test coverage
- Code is clear and maintainable
No changes required before merge.
rmarinho
added
s/agent-changes-requested
kubaflo
requested changes
Feb 16, 2026
Contributor
kubaflo
left a comment
kubaflo
left a comment
There was a problem hiding this comment.
HI @NanthiniMahalingam could you please see the AI Summary comment and try to implement the try-fix #1? Thanks!
Vignesh-SF3580
force-pushed
the
Fix-31825
branch
from
1885d14 to
3ef3c01
Compare
Contributor
@kubaflo I’ve implemented the Copilot suggestion, and it works as expected. |
kubaflo
added
the
s/agent-fix-implemented
…otnet#34548) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## Description Adds a [gh-aw (GitHub Agentic Workflows)](https://github.github.com/gh-aw/introduction/overview/) workflow that automatically evaluates test quality on PRs using the `evaluate-pr-tests` skill. ### What it does When a PR adds or modifies test files, this workflow: 1. **Checks out the PR branch** (including fork PRs) in a pre-agent step 2. **Runs the `evaluate-pr-tests` skill** via Copilot CLI in a sandboxed container 3. **Posts the evaluation report** as a PR comment using gh-aw safe-outputs ### Triggers | Trigger | When | Fork PR support | |---------|------|-----------------| | `pull_request` | Automatic on test file changes (`src/**/tests/**`) | ❌ Blocked by `pre_activation` gate | | `workflow_dispatch` | Manual — enter PR number | ✅ Works for all PRs | | `issue_comment` (`/evaluate-tests`) | Comment on PR |⚠️ Same-repo only (see Known Limitations) | ### Security model | Layer | Implementation | |-------|---------------| | **gh-aw sandbox** | Agent runs in container with scrubbed credentials, network firewall | | **Safe outputs** | Max 1 PR comment per run, content-limited | | **Checkout without execution** | `steps:` checks out PR code but never executes workspace scripts | | **Base branch restoration** | `.github/skills/`, `.github/instructions/`, `.github/copilot-instructions.md` restored from base branch after checkout | | **Fork PR activation gate** | `pull_request` events blocked for forks via `head.repo.id == repository_id` | | **Pinned actions** | SHA-pinned `actions/checkout`, `actions/github-script`, etc. | | **Minimal permissions** | Each job declares only what it needs | | **Concurrency** | One evaluation per PR, cancels in-progress | | **Threat detection** | gh-aw built-in threat detection analyzes agent output | ### Files added/modified - `.github/workflows/copilot-evaluate-tests.md` — gh-aw workflow source - `.github/workflows/copilot-evaluate-tests.lock.yml` — Compiled workflow (auto-generated by `gh aw compile`) - `.github/skills/evaluate-pr-tests/scripts/Gather-TestContext.ps1` — Test context gathering script (binary-safe file download, path traversal protection) - `.github/instructions/gh-aw-workflows.instructions.md` — Copilot instructions for gh-aw development ### Known Limitations **Fork PR evaluation via `/evaluate-tests` comment is not supported in v1.** The gh-aw platform inserts a `checkout_pr_branch.cjs` step after all user steps, which may overwrite base-branch skill files restored for fork PRs. This is a known gh-aw platform limitation — user steps always run before platform-generated steps, with no way to insert steps after. **Workaround:** Use `workflow_dispatch` (Actions UI → "Run workflow" → enter PR number) to evaluate fork PRs. This trigger bypasses the platform checkout step entirely and works correctly. **Related upstream issues:** - [github/gh-aw#18481](github/gh-aw#18481) — "Using gh-aw in forks of repositories" - [github/gh-aw#18518](github/gh-aw#18518) — Fork detection and warning in `gh aw init` - [github/gh-aw#18520](github/gh-aw#18520) — Fork context hint in failure messages - [github/gh-aw#18521](github/gh-aw#18521) — Fork support documentation ### Fixes - Fixes dotnet#34602 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jakub Florkowski <kubaflo123@gmail.com>
## Summary Enables the copilot-evaluate-tests gh-aw workflow to run on fork PRs by adding `forks: ["*"]` to the `pull_request` trigger and removing the fork guard from `Checkout-GhAwPr.ps1`. ## Changes 1. **copilot-evaluate-tests.md**: Added `forks: ["*"]` to opt out of gh-aw auto-injected fork activation guard. Scoped `Checkout-GhAwPr.ps1` step to `workflow_dispatch` only (redundant for other triggers since platform handles checkout). 2. **copilot-evaluate-tests.lock.yml**: Recompiled via `gh aw compile` — fork guard removed from activation `if:` conditions. 3. **Checkout-GhAwPr.ps1**: Removed the `isCrossRepository` fork guard. Updated header docs and restore comments to accurately describe behavior for all trigger×fork combinations (including corrected step ordering). 4. **gh-aw-workflows.instructions.md**: Updated all stale references to the removed fork guard. Documented `forks: ["*"]` opt-in, clarified residual risk model for fork PRs, and updated troubleshooting table. ## Security Model Fork PRs are safe because: - Agent runs in **sandboxed container** with all credentials scrubbed - Output limited to **1 comment** via `safe-outputs: add-comment: max: 1` - Agent **prompt comes from base branch** (`runtime-import`) — forks cannot alter instructions - Pre-flight check catches missing `SKILL.md` if fork isn't rebased on `main` - No workspace code is executed with `GITHUB_TOKEN` (checkout without execution) ## Testing - ✅ `workflow_dispatch` tested against fork PR dotnet#34621 - ✅ Lock.yml statically verified — fork guard removed from `if:` conditions - ⏳ `pull_request` trigger on fork PRs can only be verified post-merge (GitHub Actions reads lock.yml from default branch) --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…taType is compiled (dotnet#34717) ## Description Adds regression tests for dotnet#34713 verifying the XAML source generator correctly handles bindings with `Converter={StaticResource ...}` inside `x:DataType` scopes. Closes dotnet#34713 ## Investigation After thorough investigation of the source generator pipeline (`KnownMarkups.cs`, `CompiledBindingMarkup.cs`, `NodeSGExtensions.cs`): ### When converter IS in page resources (compile-time resolution ✅) `GetResourceNode()` walks the XAML tree, finds the converter resource, and `ProvideValueForStaticResourceExtension` returns the variable directly — **no runtime `ProvideValue` call**. The converter is referenced at compile time. ### When converter is NOT in page resources (runtime resolution ✅) `GetResourceNode()` returns null → falls through to `IsValueProvider` → generates `StaticResourceExtension.ProvideValue(serviceProvider)`. The `SimpleValueTargetProvider` provides the full parent chain, and `TryGetApplicationLevelResource` checks `Application.Current.Resources`. The binding IS still compiled into a `TypedBinding` — only the converter resolution is deferred. ### Verified on both `main` and `net11.0` All tests pass on both branches. ## Tests added | Test | What it verifies | |------|-----------------| | `SourceGenResolvesConverterAtCompileTime_ImplicitResources` | Converter in implicit `<Resources>` → compile-time resolution, no `ProvideValue` | | `SourceGenResolvesConverterAtCompileTime_ExplicitResourceDictionary` | Converter in explicit `<ResourceDictionary>` → compile-time resolution, no `ProvideValue` | | `SourceGenCompilesBindingWithConverterToTypedBinding` | Converter NOT in page resources → still compiled to `TypedBinding`, no raw `Binding` fallback | | `BindingWithConverterFromAppResourcesWorksCorrectly` × 3 | Runtime behavior correct for all inflators (Runtime, XamlC, SourceGen) | Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
|
Vignesh-SF3580
force-pushed
the
Fix-31825
branch
from
a485b9b to
2d4734c
Compare
Contributor
I have resolved the conflicts. |
Collaborator
🚦 Gate - Test Before and After Fix📊 Expand Full Gate —
|
| Test | Without Fix (expect FAIL) | With Fix (expect PASS) |
|---|---|---|
🖥️ Issue31825 Issue31825 |
✅ FAIL — 228s | ✅ PASS — 87s |
🔴 Without fix — 🖥️ Issue31825: FAIL ✅ · 228s
Determining projects to restore...
Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj (in 505 ms).
Restored /Users/cloudtest/vss/_work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 646 ms).
Restored /Users/cloudtest/vss/_work/1/s/src/Essentials/src/Essentials.csproj (in 16.86 sec).
Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 17.1 sec).
Restored /Users/cloudtest/vss/_work/1/s/src/Controls/Foldable/src/Controls.Foldable.csproj (in 17.13 sec).
Restored /Users/cloudtest/vss/_work/1/s/src/BlazorWebView/src/Maui/Microsoft.AspNetCore.Components.WebView.Maui.csproj (in 17.14 sec).
Restored /Users/cloudtest/vss/_work/1/s/src/Core/src/Core.csproj (in 17.12 sec).
Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Xaml/Controls.Xaml.csproj (in 17.13 sec).
Restored /Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj (in 17.17 sec).
Restored /Users/cloudtest/vss/_work/1/s/src/Controls/Maps/src/Controls.Maps.csproj (in 17.19 sec).
Restored /Users/cloudtest/vss/_work/1/s/src/Core/maps/src/Maps.csproj (in 17.19 sec).
/Users/cloudtest/vss/_work/1/s/.dotnet/packs/Microsoft.iOS.Sdk.net10.0_26.0/26.0.11017/targets/Xamarin.Shared.Sdk.targets(309,3): warning : RuntimeIdentifier was set on the command line, and will override the value for RuntimeIdentifiers set in the project file. [/Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-ios]
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0-ios26.0/Microsoft.Maui.Graphics.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0-ios26.0/Microsoft.Maui.Essentials.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0-ios26.0/Microsoft.Maui.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Maps/Debug/net10.0-ios26.0/Microsoft.Maui.Maps.dll
Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
Controls.Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Maps.dll
Controls.Xaml -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Xaml.dll
Microsoft.AspNetCore.Components.WebView.Maui -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-ios26.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
Controls.Foldable -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Foldable.dll
Detected signing identity:
Code Signing Key: "" (-)
Provisioning Profile: "" () - no entitlements
Bundle Id: com.microsoft.maui.uitests
App Id: com.microsoft.maui.uitests
Controls.TestCases.HostApp -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-ios/iossimulator-arm64/Controls.TestCases.HostApp.dll
Optimizing assemblies for size may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
Optimizing assemblies for size. This process might take a while.
Build succeeded.
/Users/cloudtest/vss/_work/1/s/.dotnet/packs/Microsoft.iOS.Sdk.net10.0_26.0/26.0.11017/targets/Xamarin.Shared.Sdk.targets(309,3): warning : RuntimeIdentifier was set on the command line, and will override the value for RuntimeIdentifiers set in the project file. [/Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-ios]
1 Warning(s)
0 Error(s)
Time Elapsed 00:01:37.08
Determining projects to restore...
Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj (in 937 ms).
Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/UITest.Core/UITest.Core.csproj (in 944 ms).
Restored /Users/cloudtest/vss/_work/1/s/src/Controls/tests/CustomAttributes/Controls.CustomAttributes.csproj (in 951 ms).
Restored /Users/cloudtest/vss/_work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 937 ms).
Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/VisualTestUtils/VisualTestUtils.csproj (in 0.8 ms).
Restored /Users/cloudtest/vss/_work/1/s/src/Essentials/src/Essentials.csproj (in 1.08 sec).
Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 310 ms).
Restored /Users/cloudtest/vss/_work/1/s/src/Core/src/Core.csproj (in 1.29 sec).
Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/UITest.NUnit/UITest.NUnit.csproj (in 1.68 sec).
Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/UITest.Appium/UITest.Appium.csproj (in 2.18 sec).
Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/UITest.Analyzers/UITest.Analyzers.csproj (in 2.71 sec).
Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/VisualTestUtils.MagickNet/VisualTestUtils.MagickNet.csproj (in 2.89 sec).
Restored /Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.iOS.Tests/Controls.TestCases.iOS.Tests.csproj (in 2.91 sec).
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
Controls.CustomAttributes -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
UITest.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
VisualTestUtils -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
VisualTestUtils.MagickNet -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
UITest.NUnit -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
UITest.Appium -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
UITest.Analyzers -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
Controls.TestCases.iOS.Tests -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
Test run for /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (arm64)
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
/Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.05] Discovering: Controls.TestCases.iOS.Tests
[xUnit.net 00:00:00.13] Discovered: Controls.TestCases.iOS.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
NUnit3TestExecutor discovered 1 of 1 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 3/30/2026 7:12:22 AM FixtureSetup for Issue31825(iOS)
>>>>> 3/30/2026 7:12:26 AM UpdateItemScrollModeDynamically Start
>>>>> 3/30/2026 7:12:42 AM UpdateItemScrollModeDynamically Stop
>>>>> 3/30/2026 7:12:42 AM Log types: syslog, crashlog, performance, safariConsole, safariNetwork, server
Failed UpdateItemScrollModeDynamically [17 s]
Error Message:
System.TimeoutException : Timed out waiting for element...
Stack Trace:
at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2757
at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2784
at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 793
at Microsoft.Maui.TestCases.Tests.Issues.Issue31825.UpdateItemScrollModeDynamically() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31825.cs:line 19
at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
NUnit Adapter 4.5.0.0: Test execution complete
Test Run Failed.
Total tests: 1
Failed: 1
Total time: 1.2644 Minutes
🟢 With fix — 🖥️ Issue31825: PASS ✅ · 87s
Determining projects to restore...
Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj (in 327 ms).
Restored /Users/cloudtest/vss/_work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 330 ms).
Restored /Users/cloudtest/vss/_work/1/s/src/Essentials/src/Essentials.csproj (in 339 ms).
Restored /Users/cloudtest/vss/_work/1/s/src/Core/src/Core.csproj (in 376 ms).
Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 387 ms).
6 of 11 projects are up-to-date for restore.
/Users/cloudtest/vss/_work/1/s/.dotnet/packs/Microsoft.iOS.Sdk.net10.0_26.0/26.0.11017/targets/Xamarin.Shared.Sdk.targets(309,3): warning : RuntimeIdentifier was set on the command line, and will override the value for RuntimeIdentifiers set in the project file. [/Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-ios]
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0-ios26.0/Microsoft.Maui.Graphics.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0-ios26.0/Microsoft.Maui.Essentials.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0-ios26.0/Microsoft.Maui.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Maps/Debug/net10.0-ios26.0/Microsoft.Maui.Maps.dll
Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
Microsoft.AspNetCore.Components.WebView.Maui -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-ios26.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
Controls.Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Maps.dll
Controls.Foldable -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Foldable.dll
Controls.Xaml -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Xaml.dll
Detected signing identity:
Code Signing Key: "" (-)
Provisioning Profile: "" () - no entitlements
Bundle Id: com.microsoft.maui.uitests
App Id: com.microsoft.maui.uitests
Controls.TestCases.HostApp -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-ios/iossimulator-arm64/Controls.TestCases.HostApp.dll
Optimizing assemblies for size may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
Optimizing assemblies for size. This process might take a while.
Build succeeded.
/Users/cloudtest/vss/_work/1/s/.dotnet/packs/Microsoft.iOS.Sdk.net10.0_26.0/26.0.11017/targets/Xamarin.Shared.Sdk.targets(309,3): warning : RuntimeIdentifier was set on the command line, and will override the value for RuntimeIdentifiers set in the project file. [/Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-ios]
1 Warning(s)
0 Error(s)
Time Elapsed 00:00:42.92
Determining projects to restore...
Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj (in 378 ms).
Restored /Users/cloudtest/vss/_work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 377 ms).
Restored /Users/cloudtest/vss/_work/1/s/src/Essentials/src/Essentials.csproj (in 378 ms).
Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 379 ms).
Restored /Users/cloudtest/vss/_work/1/s/src/Core/src/Core.csproj (in 402 ms).
8 of 13 projects are up-to-date for restore.
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
Controls.CustomAttributes -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13687620
Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
UITest.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
VisualTestUtils -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
UITest.Appium -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
UITest.NUnit -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
VisualTestUtils.MagickNet -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
UITest.Analyzers -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
Controls.TestCases.iOS.Tests -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
Test run for /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (arm64)
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
/Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.04] Discovering: Controls.TestCases.iOS.Tests
[xUnit.net 00:00:00.13] Discovered: Controls.TestCases.iOS.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
NUnit3TestExecutor discovered 1 of 1 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 3/30/2026 7:14:06 AM FixtureSetup for Issue31825(iOS)
>>>>> 3/30/2026 7:14:10 AM UpdateItemScrollModeDynamically Start
>>>>> 3/30/2026 7:14:12 AM UpdateItemScrollModeDynamically Stop
Passed UpdateItemScrollModeDynamically [1 s]
NUnit Adapter 4.5.0.0: Test execution complete
Test Run Successful.
Total tests: 1
Passed: 1
Total time: 18.1579 Seconds
📁 Fix files reverted (2 files)
eng/pipelines/ci-copilot.ymlsrc/Controls/src/Core/Handlers/Items2/iOS/LayoutFactory2.cs
Collaborator
🤖 AI Summary📊 Expand Full Review —
|
| # | Source | Approach | Test Result | Files Changed | Notes |
|---|---|---|---|---|---|
| PR | PR #32191 | Store ItemsLayout ref in layout; read ItemsUpdatingScrollMode dynamically at FinalizeCollectionViewUpdates |
✅ PASSED (Gate) | LayoutFactory2.cs, ItemsViewHandler2.iOS.cs |
Agent-suggested fix, implemented by author |
🔧 Fix — Analysis & Comparison
Fix Candidates
| # | Source | Approach | Test Result | Files Changed | Notes |
|---|---|---|---|---|---|
| PR | PR #32191 | Store ItemsLayout ref; read ItemsUpdatingScrollMode dynamically in FinalizeCollectionViewUpdates |
✅ PASSED (Gate) | LayoutFactory2.cs, ItemsViewHandler2.iOS.cs |
Agent-suggested fix, author implemented |
| 1 | try-fix (claude-opus-4.6) | Store Func<ItemsUpdatingScrollMode>? delegate (closure over ItemsLayout) — layout class fully decoupled from ItemsLayout type | ✅ PASS | LayoutFactory2.cs | Cleaner encapsulation, same runtime behavior |
| 2 | try-fix (claude-sonnet-4.6) | Interface-based push (IScrollModeUpdatable) — mapper eagerly pushes new mode to layout via interface; layout stores simple ItemsUpdatingScrollMode field, updated on change | ✅ PASS | LayoutFactory2.cs, ItemsViewHandler2.iOS.cs | Eager-push vs lazy-pull; adds interface |
| 3 | try-fix (gpt-5.3-codex) | Call UpdateLayout() in mapper when mode changes — forces full layout recreation with new mode baked in; no changes to LayoutFactory2.cs at all | ✅ PASS | ItemsViewHandler2.iOS.cs only | Simplest handler-only fix; heavier (full layout recreate) |
| 5 | try-fix (claude-opus-4.6, cross-poll) | PropertyChanged subscription in CustomUICollectionViewCompositionalLayout; reactive field sync + Dispose() cleanup | ✅ PASS | LayoutFactory2.cs, ItemsViewHandler2.iOS.cs, ItemsLayout.cs | More invasive (3 files); adds event plumbing |
| 6 | try-fix (claude-sonnet-4.6, cross-poll) | IScrollModeSource interface on ItemsViewDelegator2; layout reads live value through CollectionView.Delegate cast — zero stored state in layout | ✅ PASS | LayoutFactory2.cs, ItemsViewDelegator2.cs | Elegant zero-state layout; reads through delegate chain |
Cross-Pollination
| Model | Round | New Ideas? | Details |
|---|---|---|---|
| claude-opus-4.6 | 2 | No | NO NEW IDEAS |
| claude-sonnet-4.6 | 2 | Yes | IScrollModeSource via Delegate → ran as Attempt 6 |
| claude-opus-4.6 | 3 | Yes | ConditionalWeakTable side-channel — static table keyed by UICollectionView; no stored refs in layout |
| claude-sonnet-4.6 | 3 | Yes | Use ApplySnapshot completion callback instead of overriding FinalizeCollectionViewUpdates |
| gpt-5.3-codex | 3 | Yes | WeakReference<ItemsView> / Func<> sourced from VirtualView |
Exhausted: Yes — Max 3 rounds reached per policy. Round 3 ideas not tested (limit reached).
Best Fix Selection
| Candidate | Files | Complexity | Pros | Cons |
|---|---|---|---|---|
| PR's fix | 2 | Low | Minimal, idiomatic, ItemsLayout ref already managed by handler |
Stores extra ref in layout |
| Attempt 1 | 1 | Low | Decouples layout from ItemsLayout type |
Func<> param unusual for constructor |
| Attempt 2 | 2 | Medium | Explicit push semantics | Adds interface overhead |
| Attempt 3 | 1 | Low-Med | Handler-only change | Recreates full layout on every mode change (heavier) |
| Attempt 5 | 3 | High | Reactive, proactive | Most invasive (3 files, event subscription + Dispose) |
| Attempt 6 | 2 | Medium | Zero layout state | Indirect delegate cast; touches ItemsViewDelegator2 |
Exhausted: Yes
Selected Fix: PR's fix — Stores ItemsLayout? reference in layout, reads ItemsUpdatingScrollMode dynamically. Most minimal (2 files), idiomatic C# null-conditional read, no layout recreation overhead, and no additional interfaces or event subscriptions. The ItemsLayout object is already the canonical configuration object that the handler manages.
📋 Report — Final Recommendation
✅ Final Recommendation: APPROVE
Phase Status
| Phase | Status | Notes |
|---|---|---|
| Pre-Flight | ✅ COMPLETE | Issue #31825 iOS/macOS regression; 3 changed files |
| Gate | ✅ PASSED | iOS — tests FAIL without fix (228s timeout), PASS with fix (87s) |
| Try-Fix | ✅ COMPLETE | 6 attempts (5 passing, 1 blocked), 3 cross-pollination rounds, exhausted |
| Report | ✅ COMPLETE |
Summary
PR #32191 fixes a .NET 10 regression where CollectionView.ItemsUpdatingScrollMode = KeepLastItemInView failed to scroll to the last item when set dynamically (after initial layout creation) on iOS/macOS. The fix is correct, minimal, and the implementation matches the agent-suggested approach from a prior review. Gate passed on iOS.
Root Cause
CustomUICollectionViewCompositionalLayout (a nested class in LayoutFactory2.cs) stored ItemsUpdatingScrollMode as a snapshot at construction time. Because CreateVerticalList/CreateHorizontalList etc. are called once when the layout is created, any subsequent changes to CollectionView.ItemsUpdatingScrollMode never reached FinalizeCollectionViewUpdates() — so ForceScrollToLastItem() was never triggered on item additions.
Fix Quality
Excellent. The PR's fix stores an ItemsLayout? reference in CustomUICollectionViewCompositionalLayout and reads _itemsLayout?.ItemsUpdatingScrollMode dynamically at FinalizeCollectionViewUpdates() time. The mapper MapItemsUpdatingScrollMode propagates changes via itemsLayout.ItemsUpdatingScrollMode = itemsView.ItemsUpdatingScrollMode, which the layout picks up on the next collection update.
Multi-model exploration confirmed this is the best approach among 6 tested alternatives:
- All alternatives passed, but this is the most minimal (2 files, ~24 lines changed)
- No layout recreation overhead (unlike Attempt 3 —
UpdateLayout()) - No interface indirection (unlike Attempts 2, 6)
- No event subscription/Dispose complexity (unlike Attempt 5)
- The
ItemsLayoutobject is already the handler's canonical configuration object
Test coverage: UI test UpdateItemScrollModeDynamically correctly verifies the fix — sets mode dynamically, adds items, waits for "Gelada" (the last item) to be visible.
Minor code note: The test binds AutomationId to the Name data property (non-unique across items). This is acceptable since the test only ever searches for the uniquely-named "Gelada" item, which is added once as the final item per test run.
CustomUICollectionViewCompositionalLayout remains a private nested class (not internal as the original pre-agent-review PR proposed) — the fix doesn't require exposing it.
MauiBot
added
s/agent-approved
kubaflo
approved these changes
Mar 30, 2026
PureWeen
pushed a commit
that referenced
this pull request
Apr 8, 2026
…rectly When Items Are Added Dynamically (#32191) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! <!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> ### Issue Details KeepLastItemInView does not keep the last item at the end of the displayed list when adding new items. ### Root Cause - When dynamically changing the ItemsUpdatingScrollMode, the ForceScrollToLastItem method was not invoked to display the last item in view because the __itemsUpdatingScrollMode field value in the LayoutFactory2 private class was not updated dynamically. ### Description of Change - Updated the __itemsUpdatingScrollMode field value in the LayoutFactory2 class through a new public method. - Changed the LayoutFactory2 class from private to internal to allow access to the public UpdateItemsUpdatingScrollMode method from the ItemsViewHandler2.iOS mapper class. Validated the behaviour in the following platforms - [x] Android - [x] Windows , - [x] iOS, - [x] MacOS ### Issues Fixed Fixes #31825 ### Output images iOS |Before|After| |--|--| | <video src="https://github.com/user-attachments/assets/f04c30f0-cf2f-4a2c-a29d-f6535e7f3137" > <video src="https://github.com/user-attachments/assets/5b85b375-fcd5-4129-896a-66cd913f3187">| <video src="https://github.com/user-attachments/assets/165b7ba1-830c-46cf-82d2-f062a777fac7">| | <video src="https://github.com/user-attachments/assets/f9de05b8-b321-4d37-b16a-b0401edcce1d" >| <video src="https://github.com/user-attachments/assets/ba66d2b2-3e3b-419c-a3f0-5e07d3cbfe48">| macOS |Before|After| |--|--| | <video src="https://github.com/user-attachments/assets/668076b6-efae-47e2-be02-b98c7dc99ecc" >| <video src="https://github.com/user-attachments/assets/7534a538-40f9-4509-b531-702c47f0f7a1">| | <video src="https://github.com/user-attachments/assets/65f6e620-effb-4365-b56b-c0673c928ee0" >| <video src="https://github.com/user-attachments/assets/6c3d6741-ebbe-4e0b-bbc6-de2546aeba12">| ---------
devanathan-vaithiyanathan
pushed a commit
to devanathan-vaithiyanathan/maui
that referenced
this pull request
Apr 9, 2026
…rectly When Items Are Added Dynamically (dotnet#32191) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! <!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> ### Issue Details KeepLastItemInView does not keep the last item at the end of the displayed list when adding new items. ### Root Cause - When dynamically changing the ItemsUpdatingScrollMode, the ForceScrollToLastItem method was not invoked to display the last item in view because the __itemsUpdatingScrollMode field value in the LayoutFactory2 private class was not updated dynamically. ### Description of Change - Updated the __itemsUpdatingScrollMode field value in the LayoutFactory2 class through a new public method. - Changed the LayoutFactory2 class from private to internal to allow access to the public UpdateItemsUpdatingScrollMode method from the ItemsViewHandler2.iOS mapper class. Validated the behaviour in the following platforms - [x] Android - [x] Windows , - [x] iOS, - [x] MacOS ### Issues Fixed Fixes dotnet#31825 ### Output images iOS |Before|After| |--|--| | <video src="https://github.com/user-attachments/assets/f04c30f0-cf2f-4a2c-a29d-f6535e7f3137" > <video src="https://github.com/user-attachments/assets/5b85b375-fcd5-4129-896a-66cd913f3187">| <video src="https://github.com/user-attachments/assets/165b7ba1-830c-46cf-82d2-f062a777fac7">| | <video src="https://github.com/user-attachments/assets/f9de05b8-b321-4d37-b16a-b0401edcce1d" >| <video src="https://github.com/user-attachments/assets/ba66d2b2-3e3b-419c-a3f0-5e07d3cbfe48">| macOS |Before|After| |--|--| | <video src="https://github.com/user-attachments/assets/668076b6-efae-47e2-be02-b98c7dc99ecc" >| <video src="https://github.com/user-attachments/assets/7534a538-40f9-4509-b531-702c47f0f7a1">| | <video src="https://github.com/user-attachments/assets/65f6e620-effb-4365-b56b-c0673c928ee0" >| <video src="https://github.com/user-attachments/assets/6c3d6741-ebbe-4e0b-bbc6-de2546aeba12">| ---------
PureWeen
pushed a commit
that referenced
this pull request
Apr 14, 2026
…rectly When Items Are Added Dynamically (#32191) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! <!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> ### Issue Details KeepLastItemInView does not keep the last item at the end of the displayed list when adding new items. ### Root Cause - When dynamically changing the ItemsUpdatingScrollMode, the ForceScrollToLastItem method was not invoked to display the last item in view because the __itemsUpdatingScrollMode field value in the LayoutFactory2 private class was not updated dynamically. ### Description of Change - Updated the __itemsUpdatingScrollMode field value in the LayoutFactory2 class through a new public method. - Changed the LayoutFactory2 class from private to internal to allow access to the public UpdateItemsUpdatingScrollMode method from the ItemsViewHandler2.iOS mapper class. Validated the behaviour in the following platforms - [x] Android - [x] Windows , - [x] iOS, - [x] MacOS ### Issues Fixed Fixes #31825 ### Output images iOS |Before|After| |--|--| | <video src="https://github.com/user-attachments/assets/f04c30f0-cf2f-4a2c-a29d-f6535e7f3137" > <video src="https://github.com/user-attachments/assets/5b85b375-fcd5-4129-896a-66cd913f3187">| <video src="https://github.com/user-attachments/assets/165b7ba1-830c-46cf-82d2-f062a777fac7">| | <video src="https://github.com/user-attachments/assets/f9de05b8-b321-4d37-b16a-b0401edcce1d" >| <video src="https://github.com/user-attachments/assets/ba66d2b2-3e3b-419c-a3f0-5e07d3cbfe48">| macOS |Before|After| |--|--| | <video src="https://github.com/user-attachments/assets/668076b6-efae-47e2-be02-b98c7dc99ecc" >| <video src="https://github.com/user-attachments/assets/7534a538-40f9-4509-b531-702c47f0f7a1">| | <video src="https://github.com/user-attachments/assets/65f6e620-effb-4365-b56b-c0673c928ee0" >| <video src="https://github.com/user-attachments/assets/6c3d6741-ebbe-4e0b-bbc6-de2546aeba12">| ---------
Merged
devanathan-vaithiyanathan
pushed a commit
to Tamilarasan-Paranthaman/maui
that referenced
this pull request
Apr 21, 2026
…rectly When Items Are Added Dynamically (dotnet#32191) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! <!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> ### Issue Details KeepLastItemInView does not keep the last item at the end of the displayed list when adding new items. ### Root Cause - When dynamically changing the ItemsUpdatingScrollMode, the ForceScrollToLastItem method was not invoked to display the last item in view because the __itemsUpdatingScrollMode field value in the LayoutFactory2 private class was not updated dynamically. ### Description of Change - Updated the __itemsUpdatingScrollMode field value in the LayoutFactory2 class through a new public method. - Changed the LayoutFactory2 class from private to internal to allow access to the public UpdateItemsUpdatingScrollMode method from the ItemsViewHandler2.iOS mapper class. Validated the behaviour in the following platforms - [x] Android - [x] Windows , - [x] iOS, - [x] MacOS ### Issues Fixed Fixes dotnet#31825 ### Output images iOS |Before|After| |--|--| | <video src="https://github.com/user-attachments/assets/f04c30f0-cf2f-4a2c-a29d-f6535e7f3137" > <video src="https://github.com/user-attachments/assets/5b85b375-fcd5-4129-896a-66cd913f3187">| <video src="https://github.com/user-attachments/assets/165b7ba1-830c-46cf-82d2-f062a777fac7">| | <video src="https://github.com/user-attachments/assets/f9de05b8-b321-4d37-b16a-b0401edcce1d" >| <video src="https://github.com/user-attachments/assets/ba66d2b2-3e3b-419c-a3f0-5e07d3cbfe48">| macOS |Before|After| |--|--| | <video src="https://github.com/user-attachments/assets/668076b6-efae-47e2-be02-b98c7dc99ecc" >| <video src="https://github.com/user-attachments/assets/7534a538-40f9-4509-b531-702c47f0f7a1">| | <video src="https://github.com/user-attachments/assets/65f6e620-effb-4365-b56b-c0673c928ee0" >| <video src="https://github.com/user-attachments/assets/6c3d6741-ebbe-4e0b-bbc6-de2546aeba12">| ---------
Ahamed-Ali
pushed a commit
that referenced
this pull request
Apr 22, 2026
…rectly When Items Are Added Dynamically (#32191) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! <!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> ### Issue Details KeepLastItemInView does not keep the last item at the end of the displayed list when adding new items. ### Root Cause - When dynamically changing the ItemsUpdatingScrollMode, the ForceScrollToLastItem method was not invoked to display the last item in view because the __itemsUpdatingScrollMode field value in the LayoutFactory2 private class was not updated dynamically. ### Description of Change - Updated the __itemsUpdatingScrollMode field value in the LayoutFactory2 class through a new public method. - Changed the LayoutFactory2 class from private to internal to allow access to the public UpdateItemsUpdatingScrollMode method from the ItemsViewHandler2.iOS mapper class. Validated the behaviour in the following platforms - [x] Android - [x] Windows , - [x] iOS, - [x] MacOS ### Issues Fixed Fixes #31825 ### Output images iOS |Before|After| |--|--| | <video src="https://github.com/user-attachments/assets/f04c30f0-cf2f-4a2c-a29d-f6535e7f3137" > <video src="https://github.com/user-attachments/assets/5b85b375-fcd5-4129-896a-66cd913f3187">| <video src="https://github.com/user-attachments/assets/165b7ba1-830c-46cf-82d2-f062a777fac7">| | <video src="https://github.com/user-attachments/assets/f9de05b8-b321-4d37-b16a-b0401edcce1d" >| <video src="https://github.com/user-attachments/assets/ba66d2b2-3e3b-419c-a3f0-5e07d3cbfe48">| macOS |Before|After| |--|--| | <video src="https://github.com/user-attachments/assets/668076b6-efae-47e2-be02-b98c7dc99ecc" >| <video src="https://github.com/user-attachments/assets/7534a538-40f9-4509-b531-702c47f0f7a1">| | <video src="https://github.com/user-attachments/assets/65f6e620-effb-4365-b56b-c0673c928ee0" >| <video src="https://github.com/user-attachments/assets/6c3d6741-ebbe-4e0b-bbc6-de2546aeba12">| ---------
PureWeen
pushed a commit
that referenced
this pull request
Apr 22, 2026
…rectly When Items Are Added Dynamically (#32191) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! <!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> ### Issue Details KeepLastItemInView does not keep the last item at the end of the displayed list when adding new items. ### Root Cause - When dynamically changing the ItemsUpdatingScrollMode, the ForceScrollToLastItem method was not invoked to display the last item in view because the __itemsUpdatingScrollMode field value in the LayoutFactory2 private class was not updated dynamically. ### Description of Change - Updated the __itemsUpdatingScrollMode field value in the LayoutFactory2 class through a new public method. - Changed the LayoutFactory2 class from private to internal to allow access to the public UpdateItemsUpdatingScrollMode method from the ItemsViewHandler2.iOS mapper class. Validated the behaviour in the following platforms - [x] Android - [x] Windows , - [x] iOS, - [x] MacOS ### Issues Fixed Fixes #31825 ### Output images iOS |Before|After| |--|--| | <video src="https://github.com/user-attachments/assets/f04c30f0-cf2f-4a2c-a29d-f6535e7f3137" > <video src="https://github.com/user-attachments/assets/5b85b375-fcd5-4129-896a-66cd913f3187">| <video src="https://github.com/user-attachments/assets/165b7ba1-830c-46cf-82d2-f062a777fac7">| | <video src="https://github.com/user-attachments/assets/f9de05b8-b321-4d37-b16a-b0401edcce1d" >| <video src="https://github.com/user-attachments/assets/ba66d2b2-3e3b-419c-a3f0-5e07d3cbfe48">| macOS |Before|After| |--|--| | <video src="https://github.com/user-attachments/assets/668076b6-efae-47e2-be02-b98c7dc99ecc" >| <video src="https://github.com/user-attachments/assets/7534a538-40f9-4509-b531-702c47f0f7a1">| | <video src="https://github.com/user-attachments/assets/65f6e620-effb-4365-b56b-c0673c928ee0" >| <video src="https://github.com/user-attachments/assets/6c3d6741-ebbe-4e0b-bbc6-de2546aeba12">| ---------
PureWeen
pushed a commit
that referenced
this pull request
Apr 28, 2026
…rectly When Items Are Added Dynamically (#32191) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! <!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> ### Issue Details KeepLastItemInView does not keep the last item at the end of the displayed list when adding new items. ### Root Cause - When dynamically changing the ItemsUpdatingScrollMode, the ForceScrollToLastItem method was not invoked to display the last item in view because the __itemsUpdatingScrollMode field value in the LayoutFactory2 private class was not updated dynamically. ### Description of Change - Updated the __itemsUpdatingScrollMode field value in the LayoutFactory2 class through a new public method. - Changed the LayoutFactory2 class from private to internal to allow access to the public UpdateItemsUpdatingScrollMode method from the ItemsViewHandler2.iOS mapper class. Validated the behaviour in the following platforms - [x] Android - [x] Windows , - [x] iOS, - [x] MacOS ### Issues Fixed Fixes #31825 ### Output images iOS |Before|After| |--|--| | <video src="https://github.com/user-attachments/assets/f04c30f0-cf2f-4a2c-a29d-f6535e7f3137" > <video src="https://github.com/user-attachments/assets/5b85b375-fcd5-4129-896a-66cd913f3187">| <video src="https://github.com/user-attachments/assets/165b7ba1-830c-46cf-82d2-f062a777fac7">| | <video src="https://github.com/user-attachments/assets/f9de05b8-b321-4d37-b16a-b0401edcce1d" >| <video src="https://github.com/user-attachments/assets/ba66d2b2-3e3b-419c-a3f0-5e07d3cbfe48">| macOS |Before|After| |--|--| | <video src="https://github.com/user-attachments/assets/668076b6-efae-47e2-be02-b98c7dc99ecc" >| <video src="https://github.com/user-attachments/assets/7534a538-40f9-4509-b531-702c47f0f7a1">| | <video src="https://github.com/user-attachments/assets/65f6e620-effb-4365-b56b-c0673c928ee0" >| <video src="https://github.com/user-attachments/assets/6c3d6741-ebbe-4e0b-bbc6-de2546aeba12">| ---------
PureWeen
added a commit
that referenced
this pull request
Apr 29, 2026
## Blazor - Fix: Filter precompressed RCL assets from MAUI Blazor Hybrid APKs by @mattleibow in #33917 <details> <summary>🔧 Fixes</summary> - [.NET MAUI Blazor Hybrid App should not precompress assets](#33773) </details> - [Windows] Fix for Runtime error when closing external window with WPF Webview Control by @BagavathiPerumal in #34006 <details> <summary>🔧 Fixes</summary> - [Runtime error when closing external window with WPF Webview Control](#32944) </details> ## Button - [Android] ImageButton CornerRadius not being applied - fix by @kubaflo in #30074 <details> <summary>🔧 Fixes</summary> - [ImageButton CornerRadius not being applied on Android](#23854) </details> - Fix Disabled visual state ignored when Button has locally-set BackgroundColor/TextColor by @Dhivya-SF4094 in #34444 <details> <summary>🔧 Fixes</summary> - [[regression/9.0] VisualState "Disabled" is not properly applied for Button with custom appearance](#34363) </details> ## CollectionView - Fix CollectionView grid spacing updates for first row and column by @KarthikRajaKalaimani in #34527 <details> <summary>🔧 Fixes</summary> - [[MAUI] I2_Vertical grid for horizontal Item Spacing and Vertical Item Spacing - horizontally updating the spacing only applies to the second column](#34257) </details> - Fix CollectionView record struct selection on Windows by @jeremy-visionaid in #33488 - [Android] Ensure disconnected ItemsViewHandler doesn't hold onto the items source by @filipnavara in #24610 <details> <summary>🔧 Fixes</summary> - [Crash on NullReferenceException with measurement cells in CollectionView](#24304) </details> - [Windows] Fixed VisualState Setters not working properly for CollectionView by @Dhivya-SF4094 in #27230 <details> <summary>🔧 Fixes</summary> - [VisualState Setters not working properly on Windows for a CollectionView](#27086) - [[regression/8.0.3] [Windows][CollectionView]Label Disappear when set Style in ContentPage.Resources](#19209) - [[Windows] Label style defined as ContentPage Resource doesn't propagate to CollectionView](#18701) </details> - [Windows] Fixed Margin doesn't work inside CollectionView EmptyView by @Dhivya-SF4094 in #29897 <details> <summary>🔧 Fixes</summary> - [Margin doesn't work inside CollectionView EmptyView](#8494) </details> - [Android, Windows] Fix CarouselView PreviousPosition/PreviousItem incorrect during animated ScrollTo() by @praveenkumarkarunanithi in #34570 <details> <summary>🔧 Fixes</summary> - [[Android] CurrentItemChangedEventArgs.PreviousItem and PositionChangedEventArgs.PreviousPosition Not Updating Correctly When Using ScrollTo or Setting Position](#29544) </details> - [iOS] CarouselView2: Update internal scroll indicators for compositional layout by @SubhikshaSf4851 in #33639 <details> <summary>🔧 Fixes</summary> - [[iOS] Horizontal Scroll Bar Not Visible on CarouselView (CV2)](#29390) </details> - [CarouselViewHandler2] Fir fox CurrentItem does not work when ItemSpacing is set by @SyedAbdulAzeemSF4852 in #32135 <details> <summary>🔧 Fixes</summary> - [[CarouselViewHandler2] CurrentItem does not work when ItemSpacing is set](#32048) </details> - [iOS] Fix for Incorrect Scroll in Loop Mode When CurrentItem Is Not Found in ItemsSource by @SyedAbdulAzeemSF4852 in #32141 <details> <summary>🔧 Fixes</summary> - [[Android & iOS] Setting an invalid CurrentItem causes scroll to last item in looped CarouselView](#32139) </details> - [Android] IndicatorView: Add TalkBack accessibility descriptions for indicators by @praveenkumarkarunanithi in #31775 <details> <summary>🔧 Fixes</summary> - [[Android] IndicatorView does not convey correct accessibility information](#31446) </details> - [iOS, macOS] Fixed CollectionView KeepLastItemInView Not Updating Correctly When Items Are Added Dynamically by @NanthiniMahalingam in #32191 <details> <summary>🔧 Fixes</summary> - [[.NET10] I9 - Scroll_Position - "KeepLastItemInView" does not keep the last item at the end of the displayed list when adding new items.](#31825) </details> - [Windows, Android] Resolved issue with dynamic Header/Footer reassignment in CollectionView. by @prakashKannanSf3972 in #28403 <details> <summary>🔧 Fixes</summary> - [[Windows, Android] Toggling Header/Footer in CollectionView Dynamically is not working](#27959) - [CollectionView HeaderTemplate and FooterTemplate are not displayed when ItemsSource is initially set to null](#28337) - [[Android] Header and Footer Not Visible in CollectionView When EmptyView is Selected First](#28351) </details> - [Android] Fix CollectionView inside disabled RefreshView blocks scroll by @Vignesh-SF3580 in #34702 <details> <summary>🔧 Fixes</summary> - [C6-The C6 page cannot scroll on Windows and Android platforms.](#34666) </details> - [Android] CollectionView: Fix SelectedItem visual state not applying when re-selecting same item by @KarthikRajaKalaimani in #31591 <details> <summary>🔧 Fixes</summary> - [CollectionView - SelectedItem visual state manager not working](#20062) </details> - [Windows] Fixed CollectionView.EmptyView can not be removed by setting it to Null by @Dhivya-SF4094 in #29487 <details> <summary>🔧 Fixes</summary> - [[Windows] CollectionView.EmptyView can not be removed by setting it to Null](#18657) - [[Windows] EmptyViewTemplate Not Working in CarouselView](#29463) - [EmptyViewTemplate does not do anything](#18551) - [[MAUI] I5_EmptyView - The data template selector cannot display the correct string.](#23330) </details> - [iOS] Support for IsSwipeEnabled on CarouselView2 by @kubaflo in #29996 <details> <summary>🔧 Fixes</summary> - [[iOS] IsSwipeEnabled Not Working on CarouselView (CV2)](#29391) </details> - [iOS, MacOS] Fixed FlowDirection not working on Header/Footer in CollectionView by @Dhivya-SF4094 in #32775 <details> <summary>🔧 Fixes</summary> - [[iOS, MacOS] FlowDirection not working on Header/Footer in CollectionView](#32771) </details> - [iOS] CollectionView: Fix drag-and-drop reordering into empty groups by @SuthiYuvaraj in #34151 <details> <summary>🔧 Fixes</summary> - [CollectionView Drag and Drop Reordering Can't Drop in Empty Group](#12008) </details> - [Android] CollectionView: Fix drag-and-drop reordering into empty groups by @SuthiYuvaraj in #31867 <details> <summary>🔧 Fixes</summary> - [CollectionView Drag and Drop Reordering Can't Drop in Empty Group](#12008) </details> - [iOS] Fix vertical CarouselView MandatorySingle snapping on iOS by @Vignesh-SF3580 in #34700 <details> <summary>🔧 Fixes</summary> - [CarouselView vertical snap points ignored on iOS with Microsoft.Maui.Controls v10.0.20 (regression from v9.0.120)](#33308) </details> - [iOS26] Fix CarouselView scrolling to wrong item when navigating to last item by @Vignesh-SF3580 in #34013 <details> <summary>🔧 Fixes</summary> - [[iOS 26] CarouselView does not scroll to the correct last item](#33770) </details> - Fixed the OnPlatform does not work for header property in Collection view by @NanthiniMahalingam in #28935 <details> <summary>🔧 Fixes</summary> - [OnPlatform does not work in Header of CollectionView](#25124) </details> - [Android] [Candidate branch] Fix VerifySelectedItemClearsOnNullAssignment, CollectionViewSelectionShouldClear, SelectedItemVisualIsCleared UI test failure on Android by @KarthikRajaKalaimani in #34928 ## DateTimePicker - [iOS] Fix for DatePicker FlowDirection Not Working on iOS by @SyedAbdulAzeemSF4852 in #30193 <details> <summary>🔧 Fixes</summary> - [[iOS] DatePicker FlowDirection Not Working on iOS](#30065) </details> ## Drawing - [Shapes] Line: Fix asymmetric Stretch.None path translation when right/bottom edge overflows by @NirmalKumarYuvaraj in #34385 <details> <summary>🔧 Fixes</summary> - [Line coordinates not computed correctly](#11404) - [Lines not drawing correctly](#26961) </details> - [Android] Fixed GraphicsView drawable is visible outside the canvas by @NirmalKumarYuvaraj in #28353 <details> <summary>🔧 Fixes</summary> - [[Android] GraphicsView， The drawn image can also be visible outside the canvas](#20834) </details> - Fixed Custom Drawable does not support binding by @NirmalKumarYuvaraj in #29442 <details> <summary>🔧 Fixes</summary> - [Custom IDrawable control does not databind to a model property when used inside a CollectionView ItemTemplate](#20991) </details> - Added a support for GradientBrushes on Shape.Stroke by @kubaflo in #22208 <details> <summary>🔧 Fixes</summary> - [GradientBrushes are not supported on Shape.Stroke](#21983) </details> ## Editor - Fixed Editor HorizontalTextAlignment does not update at run time by @NirmalKumarYuvaraj in #25129 <details> <summary>🔧 Fixes</summary> - [Editor HorizontalTextAlignment Does not Works.](#10987) - [[iOS/MacOs] Right-To-Left (RTL) alignment is not applied to Editor placeholder](#30052) </details> - [Windows] Fixed Entry Editor placeholder Text CharacterSpacing by @SubhikshaSf4851 in #30324 <details> <summary>🔧 Fixes</summary> - [[Windows] CharacterSpacing not applied to Placeholder text in Entry and Editor controls](#30071) </details> ## Entry - [Windows] Fix fo setting an Entry's Keyboard to Date causes it to be interpreted as a password input by @SyedAbdulAzeemSF4852 in #29344 <details> <summary>🔧 Fixes</summary> - [[Windows] Entry Keyboad-Type "Date" results in Password-Entry](#28975) </details> - [Android] Exception thrown when give more than 5000 characters to the Text property of Entry. by @KarthikRajaKalaimani in #30242 <details> <summary>🔧 Fixes</summary> - [Android crash when Entry has >5000 characters](#30144) </details> ## Essentials - Bump MonoApiToolsMSBuildTasksPackageVersion to 0.5.0 and ship Essentials.AI public APIs by @mattleibow via @Copilot in #34574 - [Mac] DeviceDisplay.KeepScreenOn not being respected on Mac OS by @HarishwaranVijayakumar in #32708 <details> <summary>🔧 Fixes</summary> - [[Mac Catalyst] DeviceDisplay.KeepScreenOn not being respected on Mac OS](#26059) </details> ## Flyoutpage - [Windows] FlyoutPage: update CollapseStyle at runtime by @devanathan-vaithiyanathan in #29927 <details> <summary>🔧 Fixes</summary> - [Flyout Page SetCollapseStyle doesn't have any change](#18200) </details> ## Gestures - [Android] Fix for TapGestureRecognizer doesn't fire by @HarishwaranVijayakumar in #34497 <details> <summary>🔧 Fixes</summary> - [[Android] TapGestureRecognizer doesn't fire](#5825) </details> ## Image - [Android] Fix Share.RequestAsync SecurityException on Android 10+ caused by missing ClipData by @HarishwaranVijayakumar in #34417 <details> <summary>🔧 Fixes</summary> - [[Bug] Share.RequestAsync throws java.lang.SecurityException (uid=1000) on Android 10+ due to missing intent.ClipData](#34370) </details> - [Windows]Fixed the MauiImage with logical name containing path issue by @sheiksyedm in #32864 <details> <summary>🔧 Fixes</summary> - [MauiImage with LogicalName containing path - is not working on Windows](#32356) </details> - [Android, Windows & iOS] Fix Downsize/ScaleImage to maintain aspect ratio and prevent upscaling by @SyedAbdulAzeemSF4852 in #30808 <details> <summary>🔧 Fixes</summary> - [[Android & Windows] In GraphicsView, the aspect ratio is not maintained when Downsize is called with both maxWidth and maxHeight](#30803) </details> ## Label - [iOS , macOS] Fixed Label text cropping when a width request is specified on the label inside a VerticalStackLayout with specified width request by @NanthiniMahalingam in #29166 <details> <summary>🔧 Fixes</summary> - [Label text gets cropped when a width request is specified on the label inside a VerticalStackLayout](#28660) - [[iOS] Label with a fixed WidthRequest has wrong height](#26644) </details> - [Android] Fix Label word wrapping clips text depending on alignment and layout options by @Dhivya-SF4094 in #34533 <details> <summary>🔧 Fixes</summary> - [Bug: Android Label word wrapping clips text depending on alignment and layout options](#34459) </details> - LineHeight and decorations for HTML Label - fix by @kubaflo in #31202 <details> <summary>🔧 Fixes</summary> - [LineHeight with HTML Label not working](#22193) - [lineheight is broken ](#22197) </details> - [iOS] Fix Label with TailTruncation not rendering after empty-to-non-empty text transition by @kubaflo in #34812 <details> <summary>🔧 Fixes</summary> - [Label with LineBreakMode="TailTruncation" does not render text if initial Text is null or empty on first render (iOS)](#34591) </details> ## Layout - [Android] Fix overflowing children clipped when parent Opacity < 1 by @SyedAbdulAzeemSF4852 in #34565 <details> <summary>🔧 Fixes</summary> - [Maui Android parent view inappropriately creates clipping mask when its opacity is less than 1, cropping out children](#22038) </details> - Fixed the FlexLayout reverse issue with the AlignContent by @Ahamed-Ali in #32134 <details> <summary>🔧 Fixes</summary> - [FlexLayout alignment issue when Wrap is set to Reverse and AlignContent is set to SpaceAround, SpaceBetween or SpaceEvenly](#31565) </details> - [iOS/Mac] Fixed BoxView in AbsoluteLayout did not return to its default AutoSize for Height and Width after reset by @Dhivya-SF4094 in #31648 <details> <summary>🔧 Fixes</summary> - [[iOS, Catalyst] BoxView in AbsoluteLayout does not return to default AutoSize for Height/Width after reset](#31496) </details> ## Map - [Windows] Implement WinUI 3 MapControl handler using Azure Maps by @jfversluis in #34138 ## Modal - [Android] PopToRootAsync for modal pages - improvements by @kubaflo in #26851 <details> <summary>🔧 Fixes</summary> - [Shell PopToRootAsync doesn't happen instantly - previous pages flash quickly. Only happens in NET 9](#26846) </details> - [Android] Fix HideSoftInputOnTapped doesn't work on Modal Pages by @HarishwaranVijayakumar in #34770 <details> <summary>🔧 Fixes</summary> - [HideSoftInputOnTapped doesn't work on Modal Pages](#34730) </details> ## Navigation - [iOS] Alert popup may be displayed on wrong window when modal page navigation is in progress - fix by @kubaflo in #31016 <details> <summary>🔧 Fixes</summary> - [Alert popup may be displayed on wrong window when modal page navigation is in progress on iOS/MacOS](#30970) </details> - [Android] Page: Fix OnNavigatedTo called twice when NavigationPage is FlyoutPage Detail by @KarthikRajaKalaimani in #31931 <details> <summary>🔧 Fixes</summary> - [NavigationPage and FlyoutPage both call OnNavigatedTo, so it is called twice](#23902) </details> ## Picker - Fixed the Picker didn't dismiss it when tapping outside on iOS and MacCatalyst platform. by @KarthikRajaKalaimani in #30067 <details> <summary>🔧 Fixes</summary> - [[regression/8.0.3] iOS Picker dismiss does not work when clicking outside of the Picker](#19168) </details> - [Windows] Fixed Picker items width wont resize back by @SubhikshaSf4851 in #33042 <details> <summary>🔧 Fixes</summary> - [Picker items width won't resize back when its container window gets resized down.](#32984) </details> ## RadioButton - Fix TalkBack not correctly narrating RadioButtons with Content by @SubhikshaSf4851 in #34521 <details> <summary>🔧 Fixes</summary> - [[Android] TalkBack does not correctly narrate RadioButtons with Content](#34322) </details> ## SafeArea - [Android] Fix SafeAreaShouldWorkOnAllShellTabs test failure on API 36 by @praveenkumarkarunanithi in #34239 ## ScrollView - [iOS] Preserve ScrollView offsets when Orientation changes to Neither by @Vignesh-SF3580 in #34672 <details> <summary>🔧 Fixes</summary> - [Incorrect implementation of ScrollView.Orientation](#34583) </details> ## Searchbar - [Android] Fix SearchBar text bleeding between instances after navigation by @SyedAbdulAzeemSF4852 in #34703 <details> <summary>🔧 Fixes</summary> - [MAUI Android: SearchBar copies content from one to the other](#20348) </details> - Fixed SearchBar CursorPosition and SelectionLength not updating when typing by @Dhivya-SF4094 in #34347 <details> <summary>🔧 Fixes</summary> - [SearchBar - CursorPosition and SelectionLength are not updated when the user types](#30779) </details> ## SearchBar - [Windows] Fixed SearchHandler issues by @Tamilarasan-Paranthaman in #29520 <details> <summary>🔧 Fixes</summary> - [[Windows] SearchHandler APIs are not functioning properly](#29493) </details> ## Shell - [iOS, Mac] Fix for Background set to Transparent doesn't have the same behavior as BackgroundColor Transparent by @HarishwaranVijayakumar in #32245 <details> <summary>🔧 Fixes</summary> - [Background set to Transparent doesn't have the same behavior as BackgroundColor = Transparent](#22769) </details> - [iOS] Fix App crash with NullReferenceException in ShellSectionRenderer by @devanathan-vaithiyanathan in #32109 <details> <summary>🔧 Fixes</summary> - [[iOS] App crash with NullReferenceException in ShellSectionRenderer](#31961) </details> - [Android] Fixed back button icon selection logic in ShellToolbarTracker by @kubaflo in #32080 <details> <summary>🔧 Fixes</summary> - [IconOverride in Shell.BackButtonBehavior does not work.](#32050) </details> - Fix TabBarIsVisible Not Updating Dynamically When Set on ShellContent by @Vignesh-SF3580 in #33090 <details> <summary>🔧 Fixes</summary> - [Shell.TabBarIsVisible is not updated dynamically at runtime](#32994) </details> - [iOS, macOS] Shell: Fix RTL flow direction for flyout, menu cells, tab bar, and Locked flyout position by @NanthiniMahalingam in #32701 <details> <summary>🔧 Fixes</summary> - [[iOS, Mac Catalyst] Shell Flyout and Content Do Not Fully Support RightToLeft (RTL)](#32419) </details> - [IOS] Inconsistent Resize Behavior for Header/Footer - fix by @kubaflo in #28713 <details> <summary>🔧 Fixes</summary> - [[IOS, Mac] Inconsistent Resize Behavior for Header/Footer](#26397) - [Enable Shell Flyout Header/Footer resize tests on iOS/Catalyst](#33501) </details> - [Android] Fix for SearchHandler retaining previous page SearchView data in pages within Shell sections by @BagavathiPerumal in #29545 <details> <summary>🔧 Fixes</summary> - [[Shell][Android] The truth is out there...but not on top tab search handlers](#8716) </details> - [Android] Fix empty space above TabBar after navigating back when TabBar visibility is toggled by @praveenkumarkarunanithi in #34324 <details> <summary>🔧 Fixes</summary> - [Empty space appears above TabBar after navigating back when TabBar visibility is toggled](#33703) - [Grid with SafeAreaEdges=Container has incorrect size when tab bar appears](#34256) </details> ## SwipeView - [Android] SwipeView: Use MeasureSpecMode.Exactly for SwipeItem layout to fix text visibility by @Ahamed-Ali in #27399 <details> <summary>🔧 Fixes</summary> - [[Android] Right SwipeView items are not visible in the SwipeView.](#27367) </details> - [Android] Prevent the tap that closes an open SwipeView from being propagated to children by @sjordanGSS in #24275 <details> <summary>🔧 Fixes</summary> - [Tapping to close a SwipeView will activate TapGestureRecognizers on .Content](#23921) </details> ## Switch - [iOS & Mac] Fix for SearchHandler retains previous page state when switching top tabs by @BagavathiPerumal in #34735 <details> <summary>🔧 Fixes</summary> - [[Shell] [iOS & Mac] SearchHandler retains previous page state when switching top tabs](#34693) </details> ## TabbedPage - [Android] Fixed NullReferenceException in app with TabBar after returning from minimized state by @NirmalKumarYuvaraj in #34779 <details> <summary>🔧 Fixes</summary> - [NullReferenceException in app with TabBar after returning from minimized state](#34720) </details> ## Titlebar - Fixed BindingContext of the Window TitleBar is not being passed on to its child content. by @NirmalKumarYuvaraj in #30080 <details> <summary>🔧 Fixes</summary> - [The BindingContext of the Window TitleBar is not being passed on to its child content.](#24831) </details> - [Windows/Mac] Fix RTL FlowDirection causes overlap with native window control buttons in TitleBar by @devanathan-vaithiyanathan in #30400 <details> <summary>🔧 Fixes</summary> - [[Windows, Mac] RTL FlowDirection causes overlap with native window control buttons in TitleBar](#30399) </details> ## WebView - [Windows] Fix WebView background color not being applied by @SubhikshaSf4851 in #34599 <details> <summary>🔧 Fixes</summary> - [WebView background color has changed after update, can't override.](#34518) </details> - [Android] Fix for WebView/HybridWebView briefly flashes full screen before layout completes by @praveenkumarkarunanithi in #33207 <details> <summary>🔧 Fixes</summary> - [[Android] HybridWebView briefly resizes to full screen when page is opened before snapping back to correct size](#31475) </details> ## Xaml - Improved style inheritance by @kubaflo in #31317 <details> <summary>🔧 Fixes</summary> - [Styles based on a style that is based on another style that uses AppThemeBinding do not inherit properties correctly.](#31280) </details> - Fix for VisualStateManager Setter.TargetName failing when ControlTemplate is applied by @BagavathiPerumal in #33208 <details> <summary>🔧 Fixes</summary> - [Setter.TargetName + ControlTemplate crash](#26977) </details> <details> <summary>🧪 Testing (4)</summary> - [Testing] Additional Feature Matrix Event Test Cases for Slider and ScrollView by @nivetha-nagalingam in #34352 - [Testing] Fixed Build error on inflight/ candidate PR 34885 by @NafeelaNazhir in #34891 - [Testing] Fixed UI test image failure in PR 34885 - [13/4/2026] by @NafeelaNazhir in #34933 - Fixed test failure - CursorPositionUpdatesWhenSearchBarGainsFocus by @Dhivya-SF4094 in #34938 </details> <details> <summary>📦 Other (3)</summary> - Fix Loaded event not called for MAUI View added to native View by @NirmalKumarYuvaraj in #34345 <details> <summary>🔧 Fixes</summary> - [Loaded event not called for MAUI View added to native View](#34310) </details> - Add public IAlertManager and IAlertManagerSubscription interfaces by @Redth in #34228 <details> <summary>🔧 Fixes</summary> - [Alert/Dialog system (`DisplayAlert`, `DisplayActionSheet`, `DisplayPromptAsync`) needs a public extensibility point](#34104) </details> - Fix crash when displaying alerts on unloaded pages by @kubaflo in #33288 </details> <details> <summary>📝 Issue References</summary> Fixes #5825, Fixes #8494, Fixes #8716, Fixes #10987, Fixes #11404, Fixes #12008, Fixes #18200, Fixes #18551, Fixes #18657, Fixes #18701, Fixes #19168, Fixes #19209, Fixes #20062, Fixes #20348, Fixes #20834, Fixes #20991, Fixes #21983, Fixes #22038, Fixes #22193, Fixes #22197, Fixes #22769, Fixes #23330, Fixes #23854, Fixes #23902, Fixes #23921, Fixes #24304, Fixes #24831, Fixes #25124, Fixes #26059, Fixes #26397, Fixes #26644, Fixes #26846, Fixes #26961, Fixes #26977, Fixes #27086, Fixes #27367, Fixes #27959, Fixes #28337, Fixes #28351, Fixes #28660, Fixes #28975, Fixes #29390, Fixes #29391, Fixes #29463, Fixes #29493, Fixes #29544, Fixes #30052, Fixes #30065, Fixes #30071, Fixes #30144, Fixes #30399, Fixes #30779, Fixes #30803, Fixes #30970, Fixes #31280, Fixes #31446, Fixes #31475, Fixes #31496, Fixes #31565, Fixes #31825, Fixes #31961, Fixes #32048, Fixes #32050, Fixes #32139, Fixes #32356, Fixes #32419, Fixes #32771, Fixes #32944, Fixes #32984, Fixes #32994, Fixes #33308, Fixes #33501, Fixes #33703, Fixes #33770, Fixes #33773, Fixes #34104, Fixes #34256, Fixes #34257, Fixes #34310, Fixes #34322, Fixes #34363, Fixes #34370, Fixes #34459, Fixes #34518, Fixes #34583, Fixes #34591, Fixes #34666, Fixes #34693, Fixes #34720, Fixes #34730 </details> **Full Changelog**: main...inflight/candidate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue Details
KeepLastItemInView does not keep the last item at the end of the displayed list when adding new items.
Root Cause
Description of Change
Validated the behaviour in the following platforms
Issues Fixed
Fixes #31825
Output images
iOS
Issue31825_before_iOS.mov
Issue31825_after_iOS.mov
issue31825_before.mov
Issue31825_after.mov
macOS
Issue31825_before_macOS.mov
Issue_31825_after_macOS.mov
before.mov
after.mov